Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

executor: migrate test-infra to testify for executor_test.go testResourceTagSuite #33603

Merged
merged 5 commits into from Apr 2, 2022
Merged

executor: migrate test-infra to testify for executor_test.go testResourceTagSuite #33603

merged 5 commits into from Apr 2, 2022

Conversation

zanpocc
Copy link
Contributor

@zanpocc zanpocc commented Mar 30, 2022

What problem does this PR solve?

Issue Number: close #33443

Problem Summary: migrate test-infra to testify

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 30, 2022 •
edited

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • hawkingrei
  • tisonkun

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Mar 30, 2022
@zanpocc
Copy link
Contributor Author

zanpocc commented Mar 30, 2022

/run-unit-test

1 similar comment
@hawkingrei
Copy link
Member

/run-unit-test

@zanpocc zanpocc force-pushed the restructure_tests_executor_testResourceTagSuite branch from e0030c8 to 7ba5679 Compare March 31, 2022 03:23
@zanpocc zanpocc requested a review from hawkingrei March 31, 2022 06:04
@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 1, 2022
@ti-chi-bot
Copy link
Member

@zanpocc: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hawkingrei
Copy link
Member

@zanpocc Please fix the test.

@zanpocc zanpocc force-pushed the restructure_tests_executor_testResourceTagSuite branch from 2fd2d08 to 0b19fe0 Compare April 2, 2022 08:08
@zanpocc zanpocc requested a review from hawkingrei April 2, 2022 08:10
@sre-bot
Copy link
Contributor

sre-bot commented Apr 2, 2022 •
edited

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/443744e20ea838fe9a7a662a98d0453666f975de

@hawkingrei
Copy link
Member

@zanpocc Please fix the conflict.

@zanpocc
Copy link
Contributor Author

zanpocc commented Apr 2, 2022

@hawkingrei Done

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 2, 2022
@hawkingrei hawkingrei requested a review from tisonkun April 2, 2022 09:02
@hawkingrei hawkingrei removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 2, 2022
tisonkun
tisonkun reviewed Apr 2, 2022
View reviewed changes
Copy link
Contributor

@tisonkun tisonkun left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zanpocc please remove:

var _ = SerialSuites(&testResourceTagSuite{&baseTestSuite{}})
type testResourceTagSuite struct{ *baseTestSuite }

@tisonkun
remove unused testResourceTagSuite
24b9ad0 
Signed-off-by: tison <wander4096@gmail.com>
tisonkun
tisonkun approved these changes Apr 2, 2022
View reviewed changes
Copy link
Contributor

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well. I can do you a favor.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 2, 2022
@tisonkun
Copy link
Contributor

tisonkun commented Apr 2, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 24b9ad0

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 2, 2022
@hawkingrei
Copy link
Member

/run-mysql-test

@ti-chi-bot ti-chi-bot merged commit bb8b8cc into pingcap:master Apr 2, 2022
@zanpocc
Copy link
Contributor Author

zanpocc commented Apr 2, 2022 •
edited

Well. I can do you a favor.

oh，thanks
I made modifications refer to pr #33482. If it is no use,I will delete this next time

@zanpocc zanpocc deleted the restructure_tests_executor_testResourceTagSuite branch April 3, 2022 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hawkingrei hawkingrei hawkingrei approved these changes

@tisonkun tisonkun tisonkun approved these changes

Assignees
No one assigned
Labels
release-note-none size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

migrate test-infra to testify for executor_test.go testResourceTagSuite
5 participants
@zanpocc @ti-chi-bot @hawkingrei @sre-bot @tisonkun