Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc, ddl: concurrent ddl framework design doc #33629

Merged
merged 18 commits into from Jun 15, 2022
Merged

doc, ddl: concurrent ddl framework design doc #33629

merged 18 commits into from Jun 15, 2022

Conversation

xiongjiwei
Copy link
Contributor

@xiongjiwei xiongjiwei commented Mar 31, 2022 •
edited

What problem does this PR solve?

Issue Number: ref #32031

Problem Summary:

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 31, 2022 •
edited

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • bb7133
  • wjhuang2016

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-linked-issue release-note-none size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed do-not-merge/needs-linked-issue labels Mar 31, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Apr 1, 2022 •
edited

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/3f42df7fba1cd173169a8764043f502ecc38892c

xiongjiwei
xiongjiwei commented Apr 1, 2022
View reviewed changes
docs/design/2022-03-31-concurrent-ddl-framawork.md
+---------------+------------+------+------+
```

Table `mysql.tidb_ddl_history` stores the finished DDL job.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can also add some other fields like table name schema name query etc.

lance6716
lance6716 reviewed Apr 12, 2022
View reviewed changes
docs/design/2022-03-31-concurrent-ddl-framawork.md Show resolved Hide resolved
docs/design/2022-03-31-concurrent-ddl-framawork.md Outdated Show resolved Hide resolved
docs/design/2022-03-31-concurrent-ddl-framawork.md Outdated Show resolved Hide resolved
docs/design/2022-03-31-concurrent-ddl-framawork.md Outdated Show resolved Hide resolved
docs/design/2022-03-31-concurrent-ddl-framawork.md Outdated Show resolved Hide resolved
docs/design/2022-03-31-concurrent-ddl-framawork.md Outdated Show resolved Hide resolved
docs/design/2022-03-31-concurrent-ddl-framawork.md Outdated Show resolved Hide resolved
@wjhuang2016 wjhuang2016 mentioned this pull request May 23, 2022
Closed
@xiongjiwei xiongjiwei marked this pull request as draft June 7, 2022 06:42
@ti-chi-bot ti-chi-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 7, 2022
@ti-chi-bot ti-chi-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 8, 2022
@xiongjiwei xiongjiwei marked this pull request as ready for review June 8, 2022 06:06
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 8, 2022
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 8, 2022
xiongjiwei and others added 3 commits June 8, 2022 19:31
@xiongjiwei xiongjiwei mentioned this pull request Jun 14, 2022
Merged
4 tasks
bb7133
bb7133 approved these changes Jun 15, 2022
View reviewed changes
Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 15, 2022
@bb7133
Copy link
Member

bb7133 commented Jun 15, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: c410830

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 15, 2022
@xiongjiwei
Copy link
Contributor Author

/hold

@ti-chi-bot ti-chi-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 15, 2022
@xiongjiwei
Copy link
Contributor Author

/unhold

@ti-chi-bot ti-chi-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 15, 2022
@ti-chi-bot ti-chi-bot merged commit 2de01b4 into pingcap:master Jun 15, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Jun 15, 2022

TiDB MergeCI notify

🔴 Bad News! New failing [1] after this pr merged.
These new failed integration tests seem to be caused by the current PR, please try to fix these new failed integration tests, thanks!

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci-tidb/common-test 🟥 failed 1, success 11, total 12 10 min New failing
idc-jenkins-ci-tidb/integration-common-test 🔴 failed 2, success 9, total 11 18 min Existing failure
idc-jenkins-ci/integration-cdc-test 🟢 all 34 tests passed 29 min Existing passed
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 6 min 44 sec Existing passed
idc-jenkins-ci-tidb/integration-ddl-test 🟢 all 6 tests passed 6 min 24 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 6 min 12 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 5 min 35 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 4 min 46 sec Existing passed
idc-jenkins-ci-tidb/mybatis-test 🟢 all 1 tests passed 3 min 14 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

@xiongjiwei xiongjiwei deleted the concurrent-ddl branch September 1, 2022 03:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lance6716 lance6716 lance6716 left review comments

@hawkingrei hawkingrei hawkingrei left review comments

@zimulala zimulala zimulala left review comments

@bb7133 bb7133 bb7133 approved these changes

@wjhuang2016 wjhuang2016 wjhuang2016 approved these changes

Assignees
No one assigned
Labels
release-note-none size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@xiongjiwei @ti-chi-bot @sre-bot @bb7133 @lance6716 @hawkingrei @zimulala @wjhuang2016