Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: refactor a few methods about cost calculation #33681

Merged
merged 6 commits into from Apr 6, 2022

Conversation

qw4990
Copy link
Contributor

@qw4990 qw4990 commented Apr 2, 2022

What problem does this PR solve?

Issue Number: close #33722

Problem Summary: planner: refactor a few methods about cost calculation

What is changed and how it works?

No logical change, just refactor:

  1. create a new dedicated method for IndexLookUp cost calculation;
  2. remove task from PhysicalIndexJoin.GetCost;

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 2, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • time-and-fate
  • xuyifangreeneyes

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-linked-issue release-note-none size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 2, 2022
@qw4990 qw4990 added type/enhancement sig/planner SIG: Planner and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 2, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Apr 2, 2022

@ti-chi-bot ti-chi-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 2, 2022
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 2, 2022
@qw4990
Copy link
Contributor Author

qw4990 commented Apr 6, 2022

/run-check_dev_2

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 6, 2022
@qw4990
Copy link
Contributor Author

qw4990 commented Apr 6, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: c151d50

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 6, 2022
@qw4990
Copy link
Contributor Author

qw4990 commented Apr 6, 2022

/run-mysql-test

@hawkingrei
Copy link
Member

/run-unit-test

@ti-chi-bot ti-chi-bot merged commit bd8c710 into pingcap:master Apr 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none sig/planner SIG: Planner size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

planner: create a dedicated GetCost method for IndexLookUpReader
6 participants