Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

server: set 'clientConn.ctx = nil' to clean the context when changeUser. #33703

Merged
merged 5 commits into from
Apr 8, 2022
Merged

server: set 'clientConn.ctx = nil' to clean the context when changeUser. #33703

merged 5 commits into from
Apr 8, 2022

Conversation

knull-cn
Copy link
Contributor

@knull-cn knull-cn commented Apr 3, 2022

What problem does this PR solve?

Issue Number: close #33699

Problem Summary: session variable was not clean when changeUser.

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 3, 2022 •
edited

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • jackysp
  • youjiali1995

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none do-not-merge/needs-triage-completed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 3, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Apr 3, 2022 •
edited

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/9a9285a1866b7d6ae974105402633f334642c47a

@knull-cn
Copy link
Contributor Author

knull-cn commented Apr 3, 2022

/check-issue-triage-complete

@morgo morgo requested review from dveeden and morgo April 4, 2022 17:50
@knull-cn
Copy link
Contributor Author

knull-cn commented Apr 6, 2022

/run-check-issue-triage-complete

@knull-cn
Copy link
Contributor Author

knull-cn commented Apr 6, 2022

/idc-jenkins-ci-tidb/check_dev_2

@knull-cn
Copy link
Contributor Author

knull-cn commented Apr 6, 2022

/run-idc-jenkins-ci-tidb/check_dev_2

@knull-cn
Copy link
Contributor Author

knull-cn commented Apr 6, 2022

/run-check_dev_2

jackysp
jackysp approved these changes Apr 6, 2022
View reviewed changes
Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 6, 2022
@knull-cn
Copy link
Contributor Author

knull-cn commented Apr 6, 2022

@bb7133 PTAL
especially unit-test

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 8, 2022
@tiancaiamao
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: bf4a4d4

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 8, 2022
@ti-chi-bot ti-chi-bot merged commit 9fecc8a into pingcap:master Apr 8, 2022
@ti-srebot ti-srebot mentioned this pull request Apr 8, 2022
Closed
4 tasks
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Apr 8, 2022
@knull-cn @ti-srebot
cherry pick pingcap#33703 to release-5.2
7ad5433 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor

cherry pick to release-5.2 in PR #33819

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Apr 8, 2022
@knull-cn @ti-srebot
cherry pick pingcap#33703 to release-5.3
c12eb83 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Apr 8, 2022
Closed
4 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.3 in PR #33820

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Apr 8, 2022
@knull-cn @ti-srebot
cherry pick pingcap#33703 to release-5.4
e552a99 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Apr 8, 2022
Merged
4 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.4 in PR #33821

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Apr 8, 2022
@knull-cn @ti-srebot
cherry pick pingcap#33703 to release-6.0
d58ef31 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Apr 8, 2022
Closed
4 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-6.0 in PR #33822

@knull-cn knull-cn mentioned this pull request Apr 12, 2022
Closed
@tiancaiamao tiancaiamao mentioned this pull request Apr 14, 2022
Closed
@tiancaiamao
Copy link
Contributor

This fix may introduce another bug #33892 which is fixed by #33894, so #33894 must be cherry-pick together with this one.

ti-chi-bot pushed a commit that referenced this pull request May 6, 2022
@ti-srebot
server: set 'clientConn.ctx = nil' to clean the context when changeUs…
52ba435 
…er. (#33703) (#33821)

close #33699
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackysp jackysp jackysp approved these changes

@youjiali1995 youjiali1995 youjiali1995 approved these changes

@dveeden dveeden Awaiting requested review from dveeden

@morgo morgo Awaiting requested review from morgo

Assignees
No one assigned
Labels
component/server needs-cherry-pick-release-5.2 needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 needs-cherry-pick-release-5.4 Type: Need cherry pick to release-5.4 release-note-none size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

server: session variables was not changed when execute the mysql command 'ComChangeUser'
7 participants
@knull-cn @ti-chi-bot @sre-bot @tiancaiamao @ti-srebot @jackysp @youjiali1995