-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
planner: refactor net seek cost calculation for IndexScan and TableScan #33717
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Please follow PR Title Format:
Or if the count of mainly changed packages are more than 3, use
After you have format title, you can leave a comment |
Please follow PR Title Format:
Or if the count of mainly changed packages are more than 3, use
After you have format title, you can leave a comment |
Please follow PR Title Format:
Or if the count of mainly changed packages are more than 3, use
After you have format title, you can leave a comment |
Please follow PR Title Format:
Or if the count of mainly changed packages are more than 3, use
After you have format title, you can leave a comment |
Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/5e5052af122e364a580e1792b93b59182241c21f |
@@ -5294,6 +5294,42 @@ func TestIssue29503(t *testing.T) { | |||
require.Len(t, res.Rows(), 2) | |||
} | |||
|
|||
func TestIndexJoinCost(t *testing.T) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I ran this test on Master locally and all IndexJoins have the same costs with this PR.
planner/core/physical_plans.go
Outdated
@@ -533,6 +536,9 @@ type PhysicalTableScan struct { | |||
PartitionInfo PartitionInfo | |||
|
|||
SampleInfo *TableSampleInfo | |||
|
|||
// required by cost calculation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
following the format underInnerIndexJoin ....
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 2b0b8a6
|
@qw4990: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
What problem does this PR solve?
Issue Number: close #33727
Problem Summary: refactor net seek cost calculation for IndexScan and TableScan
What is changed and how it works?
Now net seek costs for
IndexScan
andTableScan
are calculated with scan costs together ingetOriginalPhysicalTableScan
andgetOriginalPhysicalIndexScan
. Better to calculate them together with net I/O costs inconvertToRootTask
andfinishIndexPlan
.Check List
Tests
Side effects
Documentation
Release note