Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

README.md: add the TiDB Cloud developer tier info #33770

Merged
merged 2 commits into from Apr 7, 2022
Merged

README.md: add the TiDB Cloud developer tier info #33770

merged 2 commits into from Apr 7, 2022

Conversation

qiancai
Copy link
Contributor

@qiancai qiancai commented Apr 7, 2022 •
edited

What problem does this PR solve?

Issue Number: close #33771

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

None

Documentation

No impact

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 7, 2022 •
edited

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Defined2014
  • sdojjy

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-linked-issue release-note-none size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 7, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Apr 7, 2022 •
edited

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/27743d54a45a67abb30f9fb8b69a66cd36186ac6

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 7, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 7, 2022
@Defined2014
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: fab7699

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 7, 2022
@Defined2014
Copy link
Contributor

/run-mysql-test

1 similar comment
@Defined2014
Copy link
Contributor

/run-mysql-test

@ti-chi-bot ti-chi-bot merged commit ef6fafa into pingcap:master Apr 7, 2022
zier-one
zier-one reviewed Apr 7, 2022
View reviewed changes
Copy link
Contributor

@zier-one zier-one left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zier-one zier-one zier-one left review comments

@sdojjy sdojjy sdojjy approved these changes

@Defined2014 Defined2014 Defined2014 approved these changes

Assignees
No one assigned
Labels
release-note-none size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TiDB README: Need to include the TiDB Cloud developer tier info
6 participants
@qiancai @ti-chi-bot @sre-bot @Defined2014 @sdojjy @zier-one