Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

topsql: remove redundant attach sql information #33806

Merged
merged 2 commits into from
Apr 8, 2022

Conversation

crazycs520
Copy link
Contributor

Signed-off-by: crazycs520 crazycs520@gmail.com

What problem does this PR solve?

Issue Number: close #33805

What is changed and how it works?

Remove redundant attach sql information operation.

Sysbench Point-Get Test

Topology

machine: AWS c4.4xlarge, 16 cpu core, 32G memory.

+------+--------------------+-------------+------------------------------------------+
| TYPE | INSTANCE           | VERSION     | GIT_HASH                                 |
+------+--------------------+-------------+------------------------------------------+
| tidb | 172.31.9.146:4000  | 6.1.0-alpha | b8d65ce20b4721c7dff7c6d90dc2db9f7582be30 |
| pd   | 172.31.9.146:2379  | 6.1.0-alpha | 8eb3bbed0584ee435be27b9f0743d640aec35d12 |
| tikv | 172.31.9.146:20160 | 6.0.0-alpha | 0cfc9afaff465f5cc3f50f9bb245694c5c1aaf4e |
+------+--------------------+-------------+------------------------------------------+

Before this PR

Threads QPS(k) with TopSQL QPS(k) Without TopSQL QPS Impact (%)
50 28775 30778 6.50789525
300 34556 37304 7.366502252

This PR

Threads QPS(k) with TopSQL QPS(k) Without TopSQL QPS Impact (%)
50 29107 30867 5.701882269
300 35022 37401 6.360792492

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: crazycs520 <crazycs520@gmail.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 8, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • breeswish
  • zhongzc

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 8, 2022
@crazycs520
Copy link
Contributor Author

/run-all-tests

1 similar comment
@crazycs520
Copy link
Contributor Author

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Apr 8, 2022

@zhongzc
Copy link
Contributor

zhongzc commented Apr 8, 2022

Does it make any difference to the topsql graph?

@crazycs520
Copy link
Contributor Author

Does it make any difference to the topsql graph?

It doesn't affect the TopSQL feature.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 8, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 8, 2022
@crazycs520
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: ef59251

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 8, 2022
@crazycs520
Copy link
Contributor Author

/merge

@ti-chi-bot ti-chi-bot merged commit cff88d7 into pingcap:master Apr 8, 2022
@crazycs520 crazycs520 deleted the topsql-opt-tiny branch April 8, 2022 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

topsql: avoid redundant attach SQL information operation
5 participants