Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

executor: add memory tracker for quering slow_query to avoid TiDB server oom #33953

Merged
merged 6 commits into from
Apr 14, 2022
Merged

executor: add memory tracker for quering slow_query to avoid TiDB server oom #33953

merged 6 commits into from
Apr 14, 2022

Conversation

crazycs520
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #33893

What is changed and how it works?

Add memory tracker for slow query.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@crazycs520
init
408d896 
Signed-off-by: crazycs520 <crazycs520@gmail.com>
@crazycs520
add memory tracker for slow query
2f8fc1e 
Signed-off-by: crazycs520 <crazycs520@gmail.com>
@crazycs520
add test
1bd0c25 
Signed-off-by: crazycs520 <crazycs520@gmail.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 14, 2022 •
edited

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • breeswish
  • wshwsh12

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-triage-completed release-note-none size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 14, 2022
@crazycs520
refine test
c4dc659 
Signed-off-by: crazycs520 <crazycs520@gmail.com>
@sre-bot
Copy link
Contributor

sre-bot commented Apr 14, 2022 •
edited

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/57a9624a69fbac7f86054bce86ae3b5cc90ce29e

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 14, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 14, 2022
@crazycs520
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 57a9624

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 14, 2022
@ti-chi-bot ti-chi-bot merged commit f988f54 into pingcap:master Apr 14, 2022
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Apr 14, 2022
@crazycs520 @ti-srebot
cherry pick pingcap#33953 to release-4.0
6791b0a 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Apr 14, 2022
Closed
4 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #33956

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Apr 14, 2022
@crazycs520 @ti-srebot
cherry pick pingcap#33953 to release-5.0
d1cb2c6 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Apr 14, 2022
Closed
4 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.0 in PR #33957

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Apr 14, 2022
@crazycs520 @ti-srebot
cherry pick pingcap#33953 to release-5.1
1e57dde 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Apr 14, 2022
Closed
4 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.1 in PR #33958

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Apr 14, 2022
@crazycs520 @ti-srebot
cherry pick pingcap#33953 to release-5.2
3d1492c 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Apr 14, 2022
Closed
4 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.2 in PR #33959

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Apr 14, 2022
@crazycs520 @ti-srebot
cherry pick pingcap#33953 to release-5.3
c41ad66 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Apr 14, 2022
Merged
4 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.3 in PR #33960

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Apr 14, 2022
@crazycs520 @ti-srebot
cherry pick pingcap#33953 to release-5.4
03cb067 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Apr 14, 2022
Merged
4 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.4 in PR #33961

@ti-srebot ti-srebot mentioned this pull request Apr 14, 2022
Closed
4 tasks
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Apr 14, 2022
@crazycs520 @ti-srebot
cherry pick pingcap#33953 to release-6.0
8e6972c 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor

cherry pick to release-6.0 in PR #33962

ti-chi-bot pushed a commit that referenced this pull request Apr 24, 2022
@ti-srebot
executor: add memory tracker for quering slow_query to avoid TiDB ser…
dc99b2d 
…ver oom (#33953) (#33961)

close #33893
@XuHuaiyu XuHuaiyu mentioned this pull request Apr 27, 2022
Open
ti-chi-bot pushed a commit that referenced this pull request Jun 14, 2022
@ti-srebot
executor: add memory tracker for quering slow_query to avoid TiDB ser…
95c590e 
…ver oom (#33953) (#33960)

close #33893
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@breezewish breezewish breezewish approved these changes

@wshwsh12 wshwsh12 wshwsh12 approved these changes

Assignees
No one assigned
Labels
needs-cherry-pick-release-5.0 needs-cherry-pick-release-5.1 needs-cherry-pick-release-5.2 needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 needs-cherry-pick-release-5.4 Type: Need cherry pick to release-5.4 release-note-none size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

query cluster_slow_query table cause TiDB server oom
6 participants
@crazycs520 @ti-chi-bot @sre-bot @ti-srebot @breezewish @wshwsh12