Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: fix index join on partition table data race #33979

Merged
merged 9 commits into from Apr 19, 2022

Conversation

tiancaiamao
Copy link
Contributor

@tiancaiamao tiancaiamao commented Apr 14, 2022

What problem does this PR solve?

Issue Number: close #33751 #33762 #32846

Problem Summary:

What is changed and how it works?

IndexJoin executor builds the inner executor in different goroutine, and PartitionPruning is called during the executor building.
PartitionPruning is not thread-safe, so the code get DATA RACE.

I use sync.Once to do PartitionPruning only once and it also avoid the DATA RACE.

pushDownNot is not thread safe, it modifies the conds slice.
I move this part to from executor building phase to physical plan phase to avoid concurrent.

And session.ParseSQL is not thread-safe, in index join, hash partition pruning, several inner executor will be built at the same time. They would call session.ParseSQL in several different goroutines.
I revert a small optimization to make session.ParseSQL thread-safe.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

Check no data race after this fix:

make ut X='run executor TestPartitionTableIndexJoinIndexLookUp --race'
make ut X='run executor TestDynamicPruningUnderIndexJoin --race'
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 14, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • mjonss
  • qw4990

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 14, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Apr 14, 2022

Copy link
Contributor

@mjonss mjonss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and thanks for the "to the point" description of the change!

I only have one small question/suggestion.

executor/builder.go Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 14, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 15, 2022
@tiancaiamao
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 0f39f6d

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 18, 2022
@tiancaiamao
Copy link
Contributor Author

/merge

@tiancaiamao
Copy link
Contributor Author

/run-check_dev

1 similar comment
@tiancaiamao
Copy link
Contributor Author

/run-check_dev

@tiancaiamao
Copy link
Contributor Author

/merge

@ti-chi-bot ti-chi-bot merged commit e21b435 into pingcap:master Apr 19, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Apr 19, 2022

TiDB MergeCI notify

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci-tidb/integration-common-test 🟢 all 11 tests passed 15 min Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 7 min 42 sec Existing passed
idc-jenkins-ci-tidb/common-test 🟢 all 12 tests passed 7 min 4 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 6 min 51 sec Existing passed
idc-jenkins-ci-tidb/integration-ddl-test 🟢 all 6 tests passed 6 min 42 sec Existing passed
idc-jenkins-ci-tidb/mybatis-test 🟢 all 1 tests passed 6 min 42 sec Existing passed
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 5 min 22 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 3 min 45 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

@tiancaiamao tiancaiamao deleted the data-race-33751 branch April 19, 2022 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FAIL] executor TestPartitionTableIndexJoinAndIndexReader
5 participants