Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

telemetry: rewrite cluster index usage info #34296

Merged
merged 19 commits into from
May 7, 2022
Merged

telemetry: rewrite cluster index usage info #34296

merged 19 commits into from
May 7, 2022

Conversation

ymkzpx
Copy link
Contributor

@ymkzpx ymkzpx commented Apr 27, 2022 •
edited

What problem does this PR solve?

Issue Number: close #34035

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 27, 2022 •
edited

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • bb7133
  • tiancaiamao

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 27, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Apr 27, 2022

Please follow PR Title Format:

  • pkg [, pkg2, pkg3]: what is changed

Or if the count of mainly changed packages are more than 3, use

  • *: what is changed

After you have format title, you can leave a comment /run-check_title to recheck it

@sre-bot
Copy link
Contributor

sre-bot commented Apr 27, 2022

Please follow PR Title Format:

  • pkg [, pkg2, pkg3]: what is changed

Or if the count of mainly changed packages are more than 3, use

  • *: what is changed

After you have format title, you can leave a comment /run-check_title to recheck it

@ymkzpx ymkzpx changed the title rewrite cluster index usage info telemetry: rewrite cluster index usage info Apr 27, 2022
@ymkzpx
Copy link
Contributor Author

ymkzpx commented Apr 27, 2022 •
edited

/run-check-title

@sre-bot
Copy link
Contributor

sre-bot commented Apr 27, 2022 •
edited

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/15cdebf7a01c767d452a15f743a0dc4ea178d5df

@bb7133
Copy link
Member

bb7133 commented Apr 27, 2022

Please add a test case for your change.

@bb7133 bb7133 added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 27, 2022
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 28, 2022
bb7133
bb7133 reviewed May 5, 2022
View reviewed changes
telemetry/data_feature_usage.go Outdated Show resolved Hide resolved
telemetry/data_feature_usage.go Outdated Show resolved Hide resolved
@ymkzpx @bb7133
Apply suggestions from code review
02905e7 
Co-authored-by: bb7133 <bb7133@gmail.com>
@ymkzpx
Copy link
Contributor Author

ymkzpx commented May 5, 2022

/run-pessimistic-test

@ymkzpx ymkzpx requested a review from bb7133 May 5, 2022 08:09
bb7133
bb7133 approved these changes May 5, 2022
View reviewed changes
Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 5, 2022
@bb7133
Copy link
Member

bb7133 commented May 5, 2022

PTAL @lcwangchao @tiancaiamao

@ymkzpx ymkzpx requested a review from tiancaiamao May 6, 2022 07:29
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 7, 2022
@tiancaiamao
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 917a30f

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 7, 2022
@ti-chi-bot ti-chi-bot merged commit 7f3afc9 into pingcap:master May 7, 2022
@sre-bot
Copy link
Contributor

sre-bot commented May 7, 2022

TiDB MergeCI notify

🔴 Bad News! New failing [1] after this pr merged.
These new failed integration tests seem to be caused by the current PR, please try to fix these new failed integration tests, thanks!

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci-tidb/common-test 🟥 failed 2, success 10, total 12 4 min 51 sec New failing
idc-jenkins-ci/integration-cdc-test 🟢 all 34 tests passed 23 min Existing passed
idc-jenkins-ci-tidb/integration-common-test 🟢 all 11 tests passed 9 min 30 sec Existing passed
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 5 min 10 sec Existing passed
idc-jenkins-ci-tidb/integration-ddl-test 🟢 all 6 tests passed 5 min 2 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 4 min 41 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 4 min 26 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 3 min 21 sec Existing passed
idc-jenkins-ci-tidb/mybatis-test 🟢 all 1 tests passed 2 min 55 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bb7133 bb7133 bb7133 approved these changes

@tiancaiamao tiancaiamao tiancaiamao approved these changes

@lcwangchao lcwangchao Awaiting requested review from lcwangchao

Assignees
No one assigned
Labels
release-note-none size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Telemetry data for TxnUsage may be too big when there are many tables
5 participants
@ymkzpx @ti-chi-bot @sre-bot @bb7133 @tiancaiamao