Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

session: migrate test-infra to testify for testSchemaSuite #34341

Merged
merged 6 commits into from
Apr 30, 2022
Merged

session: migrate test-infra to testify for testSchemaSuite #34341

merged 6 commits into from
Apr 30, 2022

Conversation

tisonkun
Copy link
Contributor

Issue Number: close #34340

None

@tisonkun
session: migrate test-infra to testify for testSchemaSuite
1dac4b8 
Signed-off-by: tison <wander4096@gmail.com>
@tisonkun
with schema lease
b39bc9e 
Signed-off-by: tison <wander4096@gmail.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 29, 2022 •
edited

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • hawkingrei
  • xhebox

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Apr 29, 2022
@tisonkun
Copy link
Contributor Author

/cc @xhebox @hawkingrei

@tisonkun
go mod tidy
58d1cc8 
Signed-off-by: tison <wander4096@gmail.com>
@sre-bot
Copy link
Contributor

sre-bot commented Apr 29, 2022 •
edited

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/87d7fd78d40334126f15e5c4e46086b1804dfb62

@tisonkun
mockstore without set lease
29740af 
Signed-off-by: tison <wander4096@gmail.com>
@tisonkun
Copy link
Contributor Author

/run-unit-test

@tisonkun
skipIfWithRealTiKV
fe86e7e 
Signed-off-by: tison <wander4096@gmail.com>
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 29, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 29, 2022
@xhebox
Copy link
Contributor

xhebox commented Apr 29, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: fe86e7e

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 29, 2022
@tisonkun
Copy link
Contributor Author

/run-mysql-test

@ti-chi-bot ti-chi-bot merged commit ce19318 into pingcap:master Apr 30, 2022
@tisonkun tisonkun deleted the issue-34340 branch April 30, 2022 00:48
@sre-bot
Copy link
Contributor

sre-bot commented Apr 30, 2022

TiDB MergeCI notify

🔴 Bad News! New failing [1] after this pr merged.
These new failed integration tests seem to be caused by the current PR, please try to fix these new failed integration tests, thanks!

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci-tidb/common-test 🟥 failed 1, success 11, total 12 5 min 1 sec New failing
idc-jenkins-ci/integration-cdc-test 🟢 all 34 tests passed 24 min Existing passed
idc-jenkins-ci-tidb/integration-common-test 🟢 all 11 tests passed 10 min Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 6 min 5 sec Existing passed
idc-jenkins-ci-tidb/integration-ddl-test 🟢 all 6 tests passed 5 min 57 sec Existing passed
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 4 min 54 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 4 min 46 sec Existing passed
idc-jenkins-ci-tidb/mybatis-test 🟢 all 1 tests passed 3 min 47 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 3 min 3 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hawkingrei hawkingrei hawkingrei approved these changes

@xhebox xhebox xhebox approved these changes

Assignees
No one assigned
Labels
release-note-none size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

migrate test-infra to testify for session_test.testSchemaSuite
5 participants
@tisonkun @ti-chi-bot @sre-bot @xhebox @hawkingrei