Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

backup: backup empty databases #34385

Merged
merged 10 commits into from
May 7, 2022
Merged

backup: backup empty databases #34385

merged 10 commits into from
May 7, 2022

Conversation

3pointer
Copy link
Contributor

@3pointer 3pointer commented May 5, 2022 •
edited

What problem does this PR solve?

Issue Number: close #33866

Problem Summary:

  • Point-in-time recovery need we backup empty database during full backup.

What is changed and how it works?

  • This PR tried to backup empty database and add an integration test.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Update the behaviour the br can backup empty databases.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented May 5, 2022 •
edited

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • YuJuncen
  • joccau

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-linked-issue release-note-none do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 5, 2022
@3pointer
Copy link
Contributor Author

3pointer commented May 5, 2022

/run-integration-br-tests

@sre-bot
Copy link
Contributor

sre-bot commented May 5, 2022 •
edited

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/5549cee12ee0581386dc339b024210c79d2f68fb

@3pointer
Copy link
Contributor Author

3pointer commented May 5, 2022

/run-integration-br-tests

@ti-chi-bot ti-chi-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 5, 2022
@3pointer
Copy link
Contributor Author

3pointer commented May 5, 2022

/run-integration-br-tests

@3pointer
Copy link
Contributor Author

3pointer commented May 5, 2022

/run-integration-br-tests

@3pointer
Copy link
Contributor Author

3pointer commented May 6, 2022

/run-integration-br-tests

@3pointer
Copy link
Contributor Author

3pointer commented May 6, 2022

/run-integration-br-tests

1 similar comment
@3pointer
Copy link
Contributor Author

3pointer commented May 6, 2022

/run-integration-br-tests

@purelind
Copy link
Contributor

purelind commented May 6, 2022

/run-build

@3pointer
Copy link
Contributor Author

3pointer commented May 6, 2022

/run-integration-br-tests

@3pointer 3pointer marked this pull request as ready for review May 6, 2022 07:29
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 6, 2022
joccau
joccau approved these changes May 6, 2022
View reviewed changes
Copy link
Member

@joccau joccau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 6, 2022
@joccau
Copy link
Member

joccau commented May 6, 2022

/cc @YuJuncen @fengou1 @WangLe1321 PATL

@ti-chi-bot
Copy link
Member

@joccau: GitHub didn't allow me to request PR reviews from the following users: PATL.

Note that only pingcap members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @YuJuncen @fengou1 @WangLe1321 PATL

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot requested a review from YuJuncen May 6, 2022 13:10
@3pointer
Copy link
Contributor Author

3pointer commented May 7, 2022

/run-integration-br-tests

@3pointer
Copy link
Contributor Author

3pointer commented May 7, 2022

/run-integration-br-tests

@3pointer
Copy link
Contributor Author

3pointer commented May 7, 2022

/run-integration-br-tests

1 similar comment
@3pointer
Copy link
Contributor Author

3pointer commented May 7, 2022

/run-integration-br-tests

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 7, 2022
@3pointer
Copy link
Contributor Author

3pointer commented May 7, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 7288a25

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 7, 2022
@YuJuncen
Copy link
Contributor

YuJuncen commented May 7, 2022

/merge

@ti-chi-bot ti-chi-bot merged commit 9339955 into pingcap:master May 7, 2022
@sre-bot
Copy link
Contributor

sre-bot commented May 7, 2022

TiDB MergeCI notify

✅ Well Done! New fixed [1] after this pr merged.

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci-tidb/common-test ✅ all 12 tests passed 6 min 53 sec Fixed
idc-jenkins-ci/integration-cdc-test 🟢 all 34 tests passed 26 min Existing passed
idc-jenkins-ci-tidb/integration-common-test 🟢 all 11 tests passed 12 min Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 7 min 35 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 6 min 43 sec Existing passed
idc-jenkins-ci-tidb/integration-ddl-test 🟢 all 6 tests passed 5 min 23 sec Existing passed
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 4 min 44 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 3 min 25 sec Existing passed
idc-jenkins-ci-tidb/mybatis-test 🟢 all 1 tests passed 3 min 10 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

@3pointer 3pointer added the needs-cherry-pick-release-5.4 Type: Need cherry pick to release-5.4 label Jun 2, 2022
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Jun 2, 2022
@3pointer @ti-srebot
cherry pick pingcap#34385 to release-5.4
5da1655 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jun 2, 2022
Open
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.4 in PR #35128

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YuJuncen YuJuncen YuJuncen approved these changes

@joccau joccau joccau approved these changes

@fengou1 fengou1 Awaiting requested review from fengou1

@WangLe1321 WangLe1321 Awaiting requested review from WangLe1321

Assignees
No one assigned
Labels
needs-cherry-pick-release-5.4 Type: Need cherry pick to release-5.4 release-note size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

br: take a backup for empty database and restore it
7 participants
@3pointer @ti-chi-bot @sre-bot @purelind @joccau @YuJuncen @ti-srebot