Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lightning: auto adjust dynamic region configuration #34537
lightning: auto adjust dynamic region configuration #34537
Changes from 14 commits
6011662
161dc22
99248e9
9f9b41b
fd2e7e2
0887fdb
0674c8a
ade1701
0faf095
535fc21
39c9eb5
3eb19d3
75ac1eb
c7fbb93
e306b74
820cdee
b8c528d
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
those code seems more like adjusting, maybe move into
config.Adjust()
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These codes are adjusting. However it's a bit hard to put them in
config.Adjust()
because some extra instances are needed. Maybe left a TODO here and refactor this in the next PR?Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.