Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

session: migrate test-infra to testify for parts of session_test #34661

Merged
merged 8 commits into from May 15, 2022
Merged

session: migrate test-infra to testify for parts of session_test #34661

merged 8 commits into from May 15, 2022

Conversation

tisonkun
Copy link
Contributor

Issue Number: ref #28328

None

@tisonkun
session: migrate test-infra to testify for parts of session_test
0e7420e 
Signed-off-by: tison <wander4096@gmail.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented May 15, 2022 •
edited

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • LittleFall
  • hawkingrei

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels May 15, 2022
@ti-chi-bot ti-chi-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels May 15, 2022
@tisonkun
fix compile
c6d238c 
Signed-off-by: tison <wander4096@gmail.com>
@sre-bot
Copy link
Contributor

sre-bot commented May 15, 2022 •
edited

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/ef4cb748087b4f65b5364c81ffe9fc698d77306d

@ti-chi-bot ti-chi-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels May 15, 2022
@tisonkun
split real tikv test suites
3c42d21 
Signed-off-by: tison <wander4096@gmail.com>
@tisonkun
cancel license check if new task pushed
7069a61 
Signed-off-by: tison <wander4096@gmail.com>
@tisonkun
fix test
e409b1e 
Signed-off-by: tison <wander4096@gmail.com>
@tisonkun
codestyle
ab9c24f 
Signed-off-by: tison <wander4096@gmail.com>
@tisonkun
Merge branch 'master' into session-tests2
ef4cb74
@tisonkun
Copy link
Contributor Author

/cc @hawkingrei @xhebox

@tisonkun
Copy link
Contributor Author

/cc @disksing @tangenta

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 15, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 15, 2022
@tisonkun
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: ef4cb74

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 15, 2022
@ti-chi-bot ti-chi-bot merged commit 90e24b9 into pingcap:master May 15, 2022
@tisonkun tisonkun deleted the session-tests2 branch May 15, 2022 10:39
@sre-bot
Copy link
Contributor

sre-bot commented May 15, 2022

TiDB MergeCI notify

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci/integration-cdc-test 🟢 all 34 tests passed 25 min Existing passed
idc-jenkins-ci-tidb/integration-common-test 🟢 all 11 tests passed 10 min Existing passed
idc-jenkins-ci-tidb/integration-ddl-test 🟢 all 6 tests passed 6 min 46 sec Existing passed
idc-jenkins-ci-tidb/common-test 🟢 all 12 tests passed 6 min 33 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 5 min 22 sec Existing passed
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 5 min 14 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 5 min 7 sec Existing passed
idc-jenkins-ci-tidb/mybatis-test 🟢 all 1 tests passed 3 min 3 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 2 min 55 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hawkingrei hawkingrei hawkingrei approved these changes

@LittleFall LittleFall LittleFall approved these changes

@xhebox xhebox Awaiting requested review from xhebox

@disksing disksing Awaiting requested review from disksing

@tangenta tangenta Awaiting requested review from tangenta

Assignees
No one assigned
Labels
release-note-none size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@tisonkun @ti-chi-bot @sre-bot @hawkingrei @LittleFall