Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

session: migrate test-infra to testify for part of session_test #34714

Merged
merged 6 commits into from May 17, 2022
Merged

session: migrate test-infra to testify for part of session_test #34714

merged 6 commits into from May 17, 2022

Conversation

tisonkun
Copy link
Contributor

@tisonkun tisonkun commented May 17, 2022 •
edited

Issue Number: ref #28328

None

@tisonkun
session: migrate test-infra to testify for session_test
267678f 
Signed-off-by: tison <wander4096@gmail.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented May 17, 2022 •
edited

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • hawkingrei
  • tangenta

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 17, 2022
@tisonkun
stage
37390f9 
Signed-off-by: tison <wander4096@gmail.com>
@sre-bot
Copy link
Contributor

sre-bot commented May 17, 2022 •
edited

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/188a62703600df6e72a2d6430352c3742fc9ce3a

@tisonkun
stage 2
248a03f 
Signed-off-by: tison <wander4096@gmail.com>
@ti-chi-bot ti-chi-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 17, 2022
@tisonkun tisonkun changed the title session: migrate test-infra to testify for session_test session: migrate test-infra to testify for part fo session_test May 17, 2022
@tisonkun tisonkun changed the title session: migrate test-infra to testify for part fo session_test session: migrate test-infra to testify for part of session_test May 17, 2022
@tisonkun tisonkun marked this pull request as ready for review May 17, 2022 01:35
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 17, 2022
@hawkingrei hawkingrei self-requested a review May 17, 2022 03:44
@tisonkun
remove empty test suite
4440323 
Signed-off-by: tison <wander4096@gmail.com>
@tisonkun
Copy link
Contributor Author

/cc @xhebox @hawkingrei @lcwangchao

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 17, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 17, 2022
@tangenta
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 4440323

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 17, 2022
@tisonkun
Copy link
Contributor Author

/run-mysql-test

1 similar comment
@hawkingrei
Copy link
Member

/run-mysql-test

@tisonkun
Copy link
Contributor Author

/build

@tisonkun
Copy link
Contributor Author

/run-build

@ti-chi-bot ti-chi-bot merged commit dc8dfed into pingcap:master May 17, 2022
@tisonkun tisonkun deleted the session-test5 branch May 17, 2022 07:39
@sre-bot
Copy link
Contributor

sre-bot commented May 17, 2022

TiDB MergeCI notify

🔴 Bad News! New failing [1] after this pr merged.
These new failed integration tests seem to be caused by the current PR, please try to fix these new failed integration tests, thanks!

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci-tidb/integration-common-test 🟥 all 11 tests passed 16 min New failing
idc-jenkins-ci/integration-cdc-test 🟢 all 34 tests passed 25 min Existing passed
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 14 min Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 13 min Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 13 min Existing passed
idc-jenkins-ci-tidb/common-test 🟢 all 12 tests passed 11 min Existing passed
idc-jenkins-ci-tidb/integration-ddl-test 🟢 all 6 tests passed 11 min Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 9 min 55 sec Existing passed
idc-jenkins-ci-tidb/mybatis-test 🟢 all 1 tests passed 7 min 52 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hawkingrei hawkingrei hawkingrei approved these changes

@tangenta tangenta tangenta approved these changes

@lcwangchao lcwangchao Awaiting requested review from lcwangchao

@xhebox xhebox Awaiting requested review from xhebox

@Defined2014 Defined2014 Awaiting requested review from Defined2014

@xiongjiwei xiongjiwei Awaiting requested review from xiongjiwei

Assignees
No one assigned
Labels
release-note-none size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@tisonkun @ti-chi-bot @sre-bot @tangenta @hawkingrei