New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ddl: fix 'alter table cache' error when SEM is enabled #34727
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/57d3c96f9d5e1d2775eb309bbe6d8e8fb4bbb1d3 |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 41db260
|
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
cherry pick to release-6.0 in PR #34759 |
TiDB MergeCI notify🔴 Bad News! [1] CI still failing after this pr merged.
|
What problem does this PR solve?
Issue Number: close #34069
Problem Summary:
What is changed and how it works?
When SEM(Security Enhanced Mode) is enable, the system tables are not allowed to modify.
'alter table cache' need to insert a record to the
mysql.table_cache_meta
table, so it get that error.Use
ExecRestrictedSQL
instead ofExecuteInternal
...The difference is,
ExecuteInternal
just set aninternal
flag and still using the current session, and it does check privilege.In contrast,
ExecRestrictedSQL
get a sessionctx from the session pool to execute the sql, and it does not check privilege.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.