planner: fix bug that planner generates wrong 2 phase aggregate plan for TiFlash #34779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
ti-chi-bot
added
do-not-merge/needs-triage-completed
release-note-none
size/L
|
Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/e605dea67573ee3a42bb3b32e05339e94d7f496b |
Reminiscent
approved these changes
May 23, 2022
ti-chi-bot
added
status/LGT1
qw4990
approved these changes
May 24, 2022
ti-chi-bot
added
status/LGT2
|
/merge |
|
This pull request has been accepted and is ready to merge. Commit hash: 3eec8a6939090c8db6f8110fe49b7bf7edc276ec
|
ti-chi-bot
added
the
status/can-merge
|
/run-all-tests |
…for TiFlash When pushing down aggregate past join operator, the planner updates the top aggregate from CompleteMode to FinalMode. But in MPP, the planner again tries to split the top aggregate into 2 stage aggregate: 1 partial aggregate on TiFlash, 1 Final aggregate on TiDB. The newly created partial aggregate will ignore the partial aggregate result that comes under the join and treats the data as standard input data, hence causes wrong result. In this patch, we disable splitting aggregate into multiple stages if the aggregate is in final mode. Close pingcap#34682
ti-chi-bot
removed
the
status/can-merge
|
/merge |
|
This pull request has been accepted and is ready to merge. Commit hash: e605dea
|
ti-chi-bot
added
the
status/can-merge
ti-srebot
pushed a commit
to ti-srebot/tidb
that referenced
this pull request
May 25, 2022
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
Merged
12 tasks
|
cherry pick to release-6.1 in PR #34932 |
TiDB MergeCI notify
|
XuHuaiyu
added
the
needs-cherry-pick-release-5.3
12 tasks
chrysan
added
the
needs-cherry-pick-release-5.4
Merged
12 tasks
|
cherry pick to release-5.4 in PR #35589 |
fixdb
added a commit
to ti-srebot/tidb
that referenced
this pull request
Jun 21, 2022
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When pushing down aggregate past join operator, the planner updates the top aggregate from CompleteMode to FinalMode. But in MPP, the planner again tries to split the top aggregate into 2 stage aggregate: 1 partial aggregate on TiFlash, 1 Final aggregate on TiDB. The newly created partial aggregate will ignore the partial aggregate result that comes under the join and treats the data as standard input data, hence causes wrong result. In this patch, we disable splitting aggregate into multiple stages if the aggregate is in final mode.
What problem does this PR solve?
Issue Number: close #34682
Problem Summary:
What is changed and how it works?
Check List
Tests
Side effects
Documentation
Release note