Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

executor: fix drop global stats #34820

Merged
merged 4 commits into from May 19, 2022
Merged

executor: fix drop global stats #34820

merged 4 commits into from May 19, 2022

Conversation

chrysan
Copy link
Contributor

@chrysan chrysan commented May 19, 2022 •
edited

What problem does this PR solve?

Issue Number: close #34815

Problem Summary:
After enabling dynamic partition prune mode, global stats are generated, but when we "drop stats <table_name>", global stats are not dropped, we have to run "drop stats <table_name> global" to drop global stats.

What is changed and how it works?

"drop stats <table_name>" can drop global stats too.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented May 19, 2022 •
edited

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Yisaer
  • qw4990

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none needs-cherry-pick-6.0 needs-cherry-pick-release-6.1 size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 19, 2022
@chrysan chrysan requested a review from qw4990 May 19, 2022 09:09
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 19, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 19, 2022
@ti-chi-bot ti-chi-bot added needs-cherry-pick-release-5.0 needs-cherry-pick-release-5.1 needs-cherry-pick-release-5.2 needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 needs-cherry-pick-release-5.4 Type: Need cherry pick to release-5.4 size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 19, 2022
@sre-bot
Copy link
Contributor

sre-bot commented May 19, 2022 •
edited

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/da6864af36a3f4941570ab434aee5a544781285f

@chrysan
Copy link
Contributor Author

chrysan commented May 19, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 74852e1

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 19, 2022
@ti-chi-bot ti-chi-bot merged commit 3d3a04e into pingcap:master May 19, 2022
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request May 19, 2022
@chrysan @ti-srebot
cherry pick pingcap#34820 to release-5.0
b2890b4 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request May 19, 2022
Closed
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.0 in PR #34826

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request May 19, 2022
@chrysan @ti-srebot
cherry pick pingcap#34820 to release-5.1
41a7d5f 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request May 19, 2022
Closed
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.1 in PR #34827

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request May 19, 2022
@chrysan @ti-srebot
cherry pick pingcap#34820 to release-5.2
88b659e 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request May 19, 2022
Closed
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.2 in PR #34828

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request May 19, 2022
@chrysan @ti-srebot
cherry pick pingcap#34820 to release-5.3
0fc75db 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request May 19, 2022
Closed
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.3 in PR #34829

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request May 19, 2022
@chrysan @ti-srebot
cherry pick pingcap#34820 to release-5.4
8223635 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request May 19, 2022
Closed
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.4 in PR #34830

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request May 19, 2022
@chrysan @ti-srebot
cherry pick pingcap#34820 to release-6.0
c98b363 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request May 19, 2022
Closed
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-6.0 in PR #34831

@ti-srebot
Copy link
Contributor

cherry pick to release-6.1 failed

@sre-bot
Copy link
Contributor

sre-bot commented May 19, 2022

TiDB MergeCI notify

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci/integration-cdc-test 🟢 all 34 tests passed 29 min Existing passed
idc-jenkins-ci-tidb/integration-common-test 🟢 all 11 tests passed 14 min Existing passed
idc-jenkins-ci-tidb/common-test 🟢 all 12 tests passed 6 min 55 sec Existing passed
idc-jenkins-ci-tidb/integration-ddl-test 🟢 all 6 tests passed 6 min 18 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 6 min 13 sec Existing passed
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 5 min 38 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 5 min 8 sec Existing passed
idc-jenkins-ci-tidb/mybatis-test 🟢 all 1 tests passed 3 min 49 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 3 min 25 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qw4990 qw4990 qw4990 approved these changes

@Yisaer Yisaer Yisaer approved these changes

Assignees
No one assigned
Labels
needs-cherry-pick-release-5.0 needs-cherry-pick-release-5.1 needs-cherry-pick-release-5.2 needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 needs-cherry-pick-release-5.4 Type: Need cherry pick to release-5.4 needs-cherry-pick-release-6.1 release-note-none size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

drop stats doesn't drop global stats for partition table
6 participants
@chrysan @ti-chi-bot @sre-bot @ti-srebot @qw4990 @Yisaer