Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

session: fix user info in general log #34853

Merged
merged 11 commits into from May 24, 2022
Merged

session: fix user info in general log #34853

merged 11 commits into from May 24, 2022

Conversation

jackysp
Copy link
Member

@jackysp jackysp commented May 20, 2022

Signed-off-by: Jack Yu jackysp@gmail.com

What problem does this PR solve?

Issue Number: close #34852

Problem Summary:
User identity stringer interface changed in #30294, it affects the user info in general log.

What is changed and how it works?

Fix it.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  1. start a cluster
  2. set tidb_general_log = 1; select 1;
  3. check tidb.log
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@jackysp
session: fix user info in general log
851dedb 
Signed-off-by: Jack Yu <jackysp@gmail.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented May 20, 2022 •
edited

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Defined2014
  • tangenta

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-triage-completed release-note-none size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 20, 2022
@jackysp jackysp requested a review from morgo May 20, 2022 04:09
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 20, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 20, 2022
@tangenta
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 851dedb

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 20, 2022
@hawkingrei
Copy link
Member

/run-mysql-test

@Defined2014
Copy link
Contributor

/hold

@ti-chi-bot ti-chi-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 23, 2022
@Defined2014
Copy link
Contributor

@jackysp some problems with UT, please fix it.

@jackysp
fix ci
8eb45c3 
Signed-off-by: Jack Yu <jackysp@gmail.com>
@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label May 23, 2022
@jackysp
Copy link
Member Author

jackysp commented May 23, 2022

Sorry for the late response, PTAL @Defined2014

@sre-bot
Copy link
Contributor

sre-bot commented May 23, 2022 •
edited

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/5b3d82b4c7903f226e9596e9dc778479b0d26d27

@Defined2014
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 8eb45c3

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 23, 2022
@jackysp jackysp removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 24, 2022
@jackysp
Copy link
Member Author

jackysp commented May 24, 2022

/run-mysql-test

@ti-chi-bot ti-chi-bot merged commit 85c595c into pingcap:master May 24, 2022
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request May 24, 2022
@jackysp @ti-srebot
cherry pick pingcap#34853 to release-5.4
e7ed67c 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request May 24, 2022
Closed
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.4 in PR #34902

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request May 24, 2022
@jackysp @ti-srebot
cherry pick pingcap#34853 to release-6.0
91b8ebf 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request May 24, 2022
Closed
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-6.0 in PR #34903

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request May 24, 2022
@jackysp @ti-srebot
cherry pick pingcap#34853 to release-6.1
9513df6 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request May 24, 2022
Closed
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-6.1 in PR #34904

@sre-bot
Copy link
Contributor

sre-bot commented May 24, 2022

TiDB MergeCI notify

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci/integration-cdc-test 🟢 all 34 tests passed 26 min Existing passed
idc-jenkins-ci-tidb/integration-common-test 🟢 all 11 tests passed 15 min Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 9 min 6 sec Existing passed
idc-jenkins-ci-tidb/common-test 🟢 all 12 tests passed 8 min 46 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 8 min 37 sec Existing passed
idc-jenkins-ci-tidb/integration-ddl-test 🟢 all 6 tests passed 8 min 16 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 7 min 59 sec Existing passed
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 7 min 4 sec Existing passed
idc-jenkins-ci-tidb/mybatis-test 🟢 all 1 tests passed 4 min 4 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Defined2014 Defined2014 Defined2014 approved these changes

@tangenta tangenta tangenta approved these changes

@morgo morgo Awaiting requested review from morgo

Assignees
No one assigned
Labels
needs-cherry-pick-release-5.4 Type: Need cherry pick to release-5.4 needs-cherry-pick-release-6.1 release-note-none size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Hostname in general log is wrong
7 participants
@jackysp @ti-chi-bot @tangenta @hawkingrei @Defined2014 @sre-bot @ti-srebot