New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: kill auto analyze when it runs too long #34950
*: kill auto analyze when it runs too long #34950
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we have manual test results for timeout kill?
sm.Kill(info.ID, true) | ||
} | ||
if strings.Contains(info.String(), "analyze") { | ||
logutil.BgLogger().Info("find analyze") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why this log?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I forget to remove the debug code. Updated.
I have tested it in my local environment. Do you mean provide a test script? |
Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/780c68e4cd5db7b622010fdb2fa37d97de3bb122 |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 663fe40
|
/hold |
…neyes/tidb into auto-analyze-timeout
/unhold |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 780c68e
|
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
cherry pick to release-6.1 in PR #35001 |
TiDB MergeCI notify🔴 Bad News! New failing [1] after this pr merged.
|
What problem does this PR solve?
Issue Number: close #34952
Problem Summary:
Auto analyze may block GC.
What is changed and how it works?
Introduce global variable
tidb_max_auto_analyze_time
, whose default value is 3600s. When the running time of auto analyze exceeds the value, we kill auto analyze.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.