Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ddl: fix alter column drop default #35072

Merged
merged 9 commits into from Jun 6, 2022
Merged

ddl: fix alter column drop default #35072

merged 9 commits into from Jun 6, 2022

Conversation

Defined2014
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #35018

Problem Summary: fix alter column drop default

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

fix `alter column drop default`

@ti-chi-bot
Copy link
Member

ti-chi-bot commented May 31, 2022 •
edited

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • tangenta
  • zimulala

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 31, 2022
@sre-bot
Copy link
Contributor

sre-bot commented May 31, 2022 •
edited

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/8df8ff0a3774972a5e151b77a25d83f1c2b4b789

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 2, 2022
zimulala
zimulala approved these changes Jun 6, 2022
View reviewed changes
Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 6, 2022
@zimulala
Copy link
Contributor

zimulala commented Jun 6, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 9ee4d20

@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #35171

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Jun 6, 2022
@Defined2014 @ti-srebot
cherry pick pingcap#35072 to release-5.0
e8a4bdf 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jun 6, 2022
Closed
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.0 in PR #35172

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Jun 6, 2022
@Defined2014 @ti-srebot
cherry pick pingcap#35072 to release-5.1
636f311 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jun 6, 2022
Closed
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.1 in PR #35173

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Jun 6, 2022
@Defined2014 @ti-srebot
cherry pick pingcap#35072 to release-5.2
a6d4785 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jun 6, 2022
Closed
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.2 in PR #35174

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Jun 6, 2022
@Defined2014 @ti-srebot
cherry pick pingcap#35072 to release-5.3
b2b4d23 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jun 6, 2022
Closed
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.3 in PR #35176

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Jun 6, 2022
@Defined2014 @ti-srebot
cherry pick pingcap#35072 to release-5.4
1c8d6ad 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jun 6, 2022
Closed
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.4 in PR #35177

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Jun 6, 2022
@Defined2014 @ti-srebot
cherry pick pingcap#35072 to release-6.0
99947bf 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jun 6, 2022
Closed
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-6.0 in PR #35178

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Jun 6, 2022
@Defined2014 @ti-srebot
cherry pick pingcap#35072 to release-6.1
582cbea 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jun 6, 2022
Closed
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-6.1 in PR #35179

Defined2014 added a commit to tangenta/tidb that referenced this pull request Jun 13, 2022
@Defined2014
ddl: fix alter column drop default (pingcap#35072)
6bcb6ab 
close pingcap#35018
Defined2014 added a commit to tangenta/tidb that referenced this pull request Jun 13, 2022
@Defined2014
Revert "ddl: fix alter column drop default (pingcap#35072)"
3f70f73 
This reverts commit 6bcb6ab.
@crazycs520 crazycs520 mentioned this pull request Feb 26, 2024
Merged
13 tasks
This was referenced Feb 28, 2024
Merged
Closed
Closed
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zimulala zimulala zimulala approved these changes

@tangenta tangenta tangenta approved these changes

@xiongjiwei xiongjiwei Awaiting requested review from xiongjiwei

Assignees
No one assigned
Labels
needs-cherry-pick-release-6.1 release-note size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Alter column xx drop default not work in TiDB
6 participants
@Defined2014 @ti-chi-bot @sre-bot @zimulala @ti-srebot @tangenta