Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

executor, statistics: analyze use MaxUint64 ts to read data #35232

Merged
merged 13 commits into from Jul 20, 2022
Merged

executor, statistics: analyze use MaxUint64 ts to read data #35232

merged 13 commits into from Jul 20, 2022

Conversation

xuyifangreeneyes
Copy link
Contributor

@xuyifangreeneyes xuyifangreeneyes commented Jun 8, 2022 •
edited

What problem does this PR solve?

Issue Number: close #35233

Problem Summary:
Snapshot analyze may meet GC life time is shorter than transaction duration or block GC.

What is changed and how it works?

Analyze use MaxUint64 ts to read data. At the end of analyze, we still incrementally update modify_count and count, which may lead to overestimation of modify_count and count. When there are lots of updates during the analyze, the overestimation help trigger auto analyze, which is considered better than underestimation(directly setting modify_count = 0 and count = analyze_row_count can lead to underestimation).

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jun 8, 2022 •
edited

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Yisaer
  • xhebox

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-linked-issue release-note-none size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 8, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Jun 8, 2022 •
edited

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/c5d9e0daec244b6f7b577c4a8d623725bb7f3495

@xuyifangreeneyes
Copy link
Contributor Author

/cc @Yisaer @chrysan @winoros @time-and-fate

@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 9, 2022
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 22, 2022
@xuyifangreeneyes
Copy link
Contributor Author

/run-mysql-test

1 similar comment
@xuyifangreeneyes
Copy link
Contributor Author

/run-mysql-test

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 30, 2022
@xuyifangreeneyes
Copy link
Contributor Author

/run-mysql-test

@xuyifangreeneyes
Copy link
Contributor Author

/build

@xuyifangreeneyes xuyifangreeneyes requested a review from a team as a code owner July 18, 2022 09:02
@ti-chi-bot ti-chi-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 18, 2022
@xuyifangreeneyes
Copy link
Contributor Author

/build

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 20, 2022
@qw4990
Copy link
Contributor

qw4990 commented Jul 20, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: e1811dd

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 20, 2022
@xuyifangreeneyes
Copy link
Contributor Author

/run-unit-test

@xuyifangreeneyes
Copy link
Contributor Author

/run-mysql-test

@xuyifangreeneyes
Copy link
Contributor Author

/run-check_dev_2

@ti-chi-bot ti-chi-bot merged commit d00b984 into pingcap:master Jul 20, 2022
@xuyifangreeneyes xuyifangreeneyes deleted the analyze-max-ts branch July 20, 2022 08:19
@sre-bot
Copy link
Contributor

sre-bot commented Jul 20, 2022

TiDB MergeCI notify

✅ Well Done! New fixed [1] after this pr merged.

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci-tidb/integration-ddl-test 🔴 failed 1, success 5, total 6 15 min Existing failure
idc-jenkins-ci-tidb/integration-common-test ✅ all 11 tests passed 31 min Fixed
idc-jenkins-ci/integration-cdc-test 🟢 all 36 tests passed 31 min Existing passed
idc-jenkins-ci-tidb/common-test 🟢 all 12 tests passed 28 min Existing passed
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 10 min Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 8 min 2 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 7 min 27 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 3 min 14 sec Existing passed
idc-jenkins-ci-tidb/mybatis-test 🟢 all 1 tests passed 3 min 14 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

This was referenced Jul 26, 2022
Closed
Merged
@chrysan chrysan mentioned this pull request Sep 14, 2022
Closed
@ti-chi-bot ti-chi-bot mentioned this pull request Jan 10, 2023
Closed
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.1: #40466.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Jan 10, 2023
@xuyifangreeneyes @ti-chi-bot
This is an automated cherry-pick of pingcap#35232
474b3b9 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@xuyifangreeneyes xuyifangreeneyes mentioned this pull request Jan 16, 2023
Merged
12 tasks
@jackysp jackysp mentioned this pull request Aug 30, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrysan chrysan chrysan approved these changes

@xhebox xhebox xhebox approved these changes

@qw4990 qw4990 qw4990 approved these changes

@Yisaer Yisaer Yisaer approved these changes

@time-and-fate time-and-fate Awaiting requested review from time-and-fate

@winoros winoros Awaiting requested review from winoros

Assignees
No one assigned
Labels
needs-cherry-pick-release-6.1 release-note-none size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

analyze use MaxUint64 ts to read data
7 participants
@xuyifangreeneyes @ti-chi-bot @sre-bot @qw4990 @chrysan @xhebox @Yisaer