Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

br: add summary to stream restore #35237

Merged
merged 9 commits into from Jun 9, 2022
Merged

br: add summary to stream restore #35237

merged 9 commits into from Jun 9, 2022

Conversation

WangLe1321
Copy link
Contributor

@WangLe1321 WangLe1321 commented Jun 8, 2022 •
edited

What problem does this PR solve?

BR restore point command has no summary. User don't know whether it finished successfully.

Issue Number: close #35236

Problem Summary: BR restore point command has no summary.

What is changed and how it works?

Add summary to tell user success or failed

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code
  1. exec restore point with full backup successfully

restore_success

  1. exec restore point without full backup successfully

restore_point_success

  1. exec restore point without full backup failed

restore_point_failed

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jun 8, 2022 •
edited

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • 3pointer
  • joccau

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 8, 2022
@WangLe1321
Copy link
Contributor Author

/component br

@ti-chi-bot ti-chi-bot added the component/br This issue is related to BR of TiDB. label Jun 8, 2022
@WangLe1321
Copy link
Contributor Author

/cc @joccau

@ti-chi-bot ti-chi-bot requested a review from joccau June 8, 2022 11:01
@WangLe1321
Copy link
Contributor Author

/cc @3pointer

@ti-chi-bot ti-chi-bot requested a review from 3pointer June 8, 2022 11:01
@WangLe1321 WangLe1321 changed the title feat: add summary to stream restore br: add summary to stream restore Jun 8, 2022
@WangLe1321
Copy link
Contributor Author

/run-integration-br-test

@WangLe1321
Copy link
Contributor Author

/cc @YuJuncen

@ti-chi-bot ti-chi-bot requested a review from YuJuncen June 8, 2022 11:03
@joccau
Copy link
Member

joccau commented Jun 8, 2022

It is a simple summary currently. We need a summary containing more useful field about restore point later.

joccau
joccau approved these changes Jun 8, 2022
View reviewed changes
Copy link
Member

@joccau joccau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 8, 2022
@joccau joccau requested review from joccau June 8, 2022 11:11
joccau
joccau approved these changes Jun 8, 2022
View reviewed changes
Copy link
Member

@joccau joccau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sre-bot
Copy link
Contributor

sre-bot commented Jun 8, 2022 •
edited

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/ec17fe88eb4d8ef69ddde021746b0383ee7ba33a

3pointer
3pointer approved these changes Jun 9, 2022
View reviewed changes
Copy link
Contributor

@3pointer 3pointer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 9, 2022
@joccau
Copy link
Member

joccau commented Jun 9, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 2bff617

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 9, 2022
@3pointer
Copy link
Contributor

3pointer commented Jun 9, 2022

/merge

@hawkingrei
Copy link
Member

/hold

@ti-chi-bot ti-chi-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 9, 2022
@hawkingrei
Copy link
Member

Wait for fixing an unstable test to merge.

@hawkingrei
Copy link
Member

/unhold

@ti-chi-bot ti-chi-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 9, 2022
@ti-chi-bot ti-chi-bot merged commit c1728d7 into pingcap:master Jun 9, 2022
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Jun 9, 2022
@WangLe1321 @ti-srebot
cherry pick pingcap#35237 to release-6.1
f832899 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jun 9, 2022
Closed
4 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-6.1 in PR #35267

@sre-bot
Copy link
Contributor

sre-bot commented Jun 9, 2022

TiDB MergeCI notify

✅ Well Done! New fixed [1] after this pr merged.

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci-tidb/integration-common-test 🔴 failed 5, success 6, total 11 15 min Existing failure
idc-jenkins-ci-tidb/sqllogic-test-2 ✅ all 28 tests passed 6 min 12 sec Fixed
idc-jenkins-ci/integration-cdc-test 🟢 all 35 tests passed 30 min Existing passed
idc-jenkins-ci-tidb/common-test 🟢 all 12 tests passed 8 min 12 sec Existing passed
idc-jenkins-ci-tidb/integration-ddl-test 🟢 all 6 tests passed 6 min 23 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 5 min 32 sec Existing passed
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 4 min 44 sec Existing passed
idc-jenkins-ci-tidb/mybatis-test 🟢 all 1 tests passed 2 min 52 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 2 min 42 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

WangLe1321 added a commit to WangLe1321/tidb that referenced this pull request Jun 10, 2022
@WangLe1321
br: add summary to stream restore (pingcap#35237)
eca470a 
close pingcap#35236
@WangLe1321 WangLe1321 mentioned this pull request Jun 10, 2022
Merged
12 tasks
joccau pushed a commit that referenced this pull request Jun 10, 2022
@WangLe1321
br: add summary to stream restore (#35237) (#35287)
fb6d018 
close #35236
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@3pointer 3pointer 3pointer approved these changes

@YuJuncen YuJuncen Awaiting requested review from YuJuncen

@joccau joccau Awaiting requested review from joccau

Assignees
No one assigned
Labels
component/br This issue is related to BR of TiDB. needs-cherry-pick-release-6.1 release-note-none size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

log-backup:Add summary to br restore point command
7 participants
@WangLe1321 @ti-chi-bot @joccau @sre-bot @3pointer @hawkingrei @ti-srebot