Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: introduce some new variables for the cost model version2 #35241

Merged
merged 15 commits into from Jun 9, 2022
Merged

planner: introduce some new variables for the cost model version2 #35241

merged 15 commits into from Jun 9, 2022

Conversation

qw4990
Copy link
Contributor

@qw4990 qw4990 commented Jun 8, 2022

What problem does this PR solve?

Issue Number: ref #35240

Problem Summary: introduce some new variables for the cost model version2

What is changed and how it works?

introduce some new variables for the cost model version2

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@qw4990 qw4990 requested a review from a team as a code owner June 8, 2022 12:31
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jun 8, 2022 •
edited

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Reminiscent
  • xuyifangreeneyes

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 8, 2022
qw4990
qw4990 commented Jun 8, 2022
View reviewed changes
sessionctx/variable/session.go
// copCPUFactorV2 is the cop-cpu factor for the Cost Model Ver2.
copCPUFactorV2 float64
// tiflashCPUFactorV2 is the cop-cpu factor for the Cost Model Ver2.
tiflashCPUFactorV2 float64
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TiFlashCPU and TiFlashScan are new factors for the cost model ver2.

@sre-bot
Copy link
Contributor

sre-bot commented Jun 8, 2022 •
edited

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/4e5e475b204f7fdb37c3504813f6ba1a7a7853d1

@qw4990 qw4990 added the sig/planner SIG: Planner label Jun 9, 2022
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 9, 2022
@qw4990
Copy link
Contributor Author

qw4990 commented Jun 9, 2022

/run-unit-test

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 9, 2022
@Reminiscent
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 764b4d2

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 9, 2022
@qw4990 qw4990 removed the status/can-merge Indicates a PR has been approved by a committer. label Jun 9, 2022
@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 9, 2022
@qw4990 qw4990 added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 9, 2022
@qw4990
Copy link
Contributor Author

qw4990 commented Jun 9, 2022

/run-unit-test

1 similar comment
@qw4990
Copy link
Contributor Author

qw4990 commented Jun 9, 2022

/run-unit-test

bb7133
bb7133 approved these changes Jun 9, 2022
View reviewed changes
Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bb7133 bb7133 removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 9, 2022
@bb7133
Copy link
Member

bb7133 commented Jun 9, 2022

/merge

@hawkingrei
Copy link
Member

/run-mysql-test

@ti-chi-bot ti-chi-bot merged commit 017ac90 into pingcap:master Jun 9, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Jun 9, 2022

TiDB MergeCI notify

🔴 Bad News! New failing [1] after this pr merged.
These new failed integration tests seem to be caused by the current PR, please try to fix these new failed integration tests, thanks!

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci-tidb/sqllogic-test-2 🟥 failed 3, success 25, total 28 5 min 25 sec New failing
idc-jenkins-ci-tidb/integration-common-test 🔴 failed 2, success 9, total 11 14 min Existing failure
idc-jenkins-ci/integration-cdc-test 🟢 all 35 tests passed 27 min Existing passed
idc-jenkins-ci-tidb/integration-ddl-test 🟢 all 6 tests passed 8 min 46 sec Existing passed
idc-jenkins-ci-tidb/common-test 🟢 all 12 tests passed 8 min 14 sec Existing passed
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 6 min 25 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 5 min 5 sec Existing passed
idc-jenkins-ci-tidb/mybatis-test 🟢 all 1 tests passed 3 min 34 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 3 min 24 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

@qw4990 qw4990 mentioned this pull request Jul 12, 2022
Closed
qw4990 added a commit to qw4990/tidb that referenced this pull request Jul 12, 2022
@qw4990
planner: introduce some new variables for the cost model version2 (pi…
761bb3c 
…ngcap#35241)

ref pingcap#35240
qw4990 added a commit to qw4990/tidb that referenced this pull request Jul 12, 2022
@qw4990
planner: introduce some new variables for the cost model version2 (pi…
701bdc1 
…ngcap#35241)

ref pingcap#35240
@qw4990 qw4990 mentioned this pull request Jul 12, 2022
Merged
qw4990 added a commit that referenced this pull request Jul 12, 2022
@qw4990
planner: introduce some new variables for the cost model version2 (#3…
6b4f278 
…5241) (#36119)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bb7133 bb7133 bb7133 approved these changes

@xuyifangreeneyes xuyifangreeneyes xuyifangreeneyes approved these changes

@Reminiscent Reminiscent Reminiscent approved these changes

@time-and-fate time-and-fate Awaiting requested review from time-and-fate

Assignees
No one assigned
Labels
release-note-none sig/planner SIG: Planner size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@qw4990 @ti-chi-bot @sre-bot @Reminiscent @bb7133 @hawkingrei @xuyifangreeneyes