planner: Manual revert of #24282

[mjonss]

What problem does this PR solve?

Issue Number: close #35181, closes #33966, ref #22079

Problem Summary:
In PR #24282 there was an optimization added to remove conditions that was used when calculating the pruned partitions, but it has issues with index-out-of-range and having other side-effects, like index usage is no-longer possible. The optimization is also very limited, since it only removes one selection/comparison (if it would be fixed to work as expected) and could only be used if the partition range is consisting of a single value. So it is better to remove the optimization.

What is changed and how it works?

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No code

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Fixed an issue with index-out-of-range and non-used-index by removing a small optimization.

[ti-chi-bot]

[REVIEW NOTIFICATION]

This pull request has been approved by:

• qw4990
• tiancaiamao

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

[sre-bot]

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/58637d750d7f2c04bfa8381e1d827ce37afc7ec0

[mjonss]

/merge

[ti-chi-bot]

This pull request has been accepted and is ready to merge.

Commit hash: 724073c

[wuhuizuo]

/label needs-cherry-pick-6.1

[wuhuizuo]

/label needs-cherry-pick-6.2

debug

[ti-srebot]

cherry pick to release-6.2 failed

[wuhuizuo]

/remove-label needs-cherry-pick-6.2

debug

[you06]

It's already in release-6.2 branch.
https://github.com/pingcap/tidb/commits/release-6.2?before=b3475f2570700ee778530d577cb3b13e38694573+35&branch=release-6.2&qualified_name=refs%2Fheads%2Frelease-6.2

[wuhuizuo]

It's already in release-6.2 branch. https://github.com/pingcap/tidb/commits/release-6.2?before=b3475f2570700ee778530d577cb3b13e38694573+35&branch=release-6.2&qualified_name=refs%2Fheads%2Frelease-6.2

ignore it, I'm diagnosing the problem: why the bot is not auto create cherry-pick pull requests

[ti-srebot]

cherry pick to release-6.1 in PR #37268

[sre-bot]

TiDB MergeCI notify

🔴 Bad News! [1] CI still failing after this pr merged.
These failed integration tests don't seem to be introduced by the current PR.

CI Name	Result	Duration	Compare with Parent commit
idc-jenkins-ci-tidb/integration-common-test	🔴 all 11 tests passed	14 min	Existing failure
idc-jenkins-ci/integration-cdc-test	🟢 all 36 tests passed	27 min	Existing passed
idc-jenkins-ci-tidb/integration-ddl-test	🟢 all 6 tests passed	7 min 29 sec	Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2	🟢 all 28 tests passed	6 min 13 sec	Existing passed
idc-jenkins-ci-tidb/common-test	🟢 all 11 tests passed	7 min 45 sec	Existing passed
idc-jenkins-ci-tidb/tics-test	🟢	25 sec	Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1	🟢 all 13 tests passed	4 min 36 sec	Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test	🟢 all 1 tests passed	3 min 10 sec	Existing passed
idc-jenkins-ci-tidb/mybatis-test	🟢 all 1 tests passed	3 min 0 sec	Existing passed
idc-jenkins-ci-tidb/plugin-test	🟢 build success, plugin test success	4min	Existing passed

[winoros]

/run-cherry-picker release-5.4

[ti-srebot]

cherry pick to release-5.4 in PR #38076