Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

executor: fix panic when granting privilege to a non-exists user #35365

Merged
merged 2 commits into from Jun 14, 2022
Merged

executor: fix panic when granting privilege to a non-exists user #35365

merged 2 commits into from Jun 14, 2022

Conversation

djshow832
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #35310

Problem Summary:

When sql_mode doesn't contain NO_AUTO_CREATE_USER and the grant statement doesn't contain a password, TiDB will panic because of a previous PR that supports auth-plugin.

What is changed and how it works?

Check nil.

Check List

Tests

  • Unit test

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jun 14, 2022 •
edited

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • tiancaiamao
  • zimulala

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@djshow832 djshow832 requested a review from dveeden June 14, 2022 06:32
@ti-chi-bot ti-chi-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 14, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Jun 14, 2022 •
edited

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/488edbbfccd392ca57f97328aa5125bde463fd96

zimulala
zimulala approved these changes Jun 14, 2022
View reviewed changes
Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 14, 2022
@zimulala
Copy link
Contributor

PTAL @tiancaiamao

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 14, 2022
@tiancaiamao
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 829403b

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 14, 2022
@hawkingrei
Copy link
Member

/run-mysql-test

1 similar comment
@hawkingrei
Copy link
Member

/run-mysql-test

@hawkingrei
Copy link
Member

@djshow832 have some problem in the tidb-test

@djshow832
Copy link
Contributor Author

/run-mysql-test tidb-test=pr/1794

@ti-chi-bot ti-chi-bot merged commit e1f9e0a into pingcap:master Jun 14, 2022
@djshow832 djshow832 deleted the fix_35310 branch June 14, 2022 09:05
@sre-bot
Copy link
Contributor

sre-bot commented Jun 14, 2022

TiDB MergeCI notify

🔴 Bad News! New failing [1] after this pr merged.
These new failed integration tests seem to be caused by the current PR, please try to fix these new failed integration tests, thanks!

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci-tidb/common-test 🟥 failed 2, success 10, total 12 13 min New failing
idc-jenkins-ci-tidb/integration-common-test 🔴 failed 2, success 9, total 11 16 min Existing failure
idc-jenkins-ci/integration-cdc-test 🟢 all 35 tests passed 31 min Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 7 min 29 sec Existing passed
idc-jenkins-ci-tidb/integration-ddl-test 🟢 all 6 tests passed 6 min 30 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 6 min 6 sec Existing passed
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 5 min 49 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 3 min 30 sec Existing passed
idc-jenkins-ci-tidb/mybatis-test 🟢 all 1 tests passed 3 min 21 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dveeden dveeden dveeden approved these changes

@tiancaiamao tiancaiamao tiancaiamao approved these changes

@zimulala zimulala zimulala approved these changes

Assignees
No one assigned
Labels
release-note-none size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

runtime error: invalid memory address or nil pointer dereference (Maybe not a bug)
7 participants
@djshow832 @ti-chi-bot @sre-bot @zimulala @tiancaiamao @hawkingrei @dveeden