Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stmtsummary: fix issue of concurrent map read and write #35367

Merged
merged 6 commits into from Jun 14, 2022
Merged

stmtsummary: fix issue of concurrent map read and write #35367

merged 6 commits into from Jun 14, 2022

Conversation

crazycs520
Copy link
Contributor

Signed-off-by: crazycs520 crazycs520@gmail.com

What problem does this PR solve?

Issue Number: close #35340

Problem Summary: statements_summary has concurrent map read and write

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@crazycs520
stmtsummary: fix issue of concurrent map read and write
cc36b02 
Signed-off-by: crazycs520 <crazycs520@gmail.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jun 14, 2022 •
edited

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • djshow832
  • tangenta

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 14, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Jun 14, 2022 •
edited

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/40e56af4efe945adf3ce4da32601e87fc22b28a5

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 14, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 14, 2022
@tangenta
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: cc36b02

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 14, 2022
@crazycs520
Copy link
Contributor Author

/run-all-tests

@crazycs520
Copy link
Contributor Author

/merge

@crazycs520
Copy link
Contributor Author

/merge

@ti-srebot ti-srebot mentioned this pull request Jun 14, 2022
Merged
4 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.2 in PR #35383

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Jun 14, 2022
@crazycs520 @ti-srebot
cherry pick pingcap#35367 to release-5.3
7568bbf 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jun 14, 2022
Merged
4 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.3 in PR #35384

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Jun 14, 2022
@crazycs520 @ti-srebot
cherry pick pingcap#35367 to release-5.4
eb18d89 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jun 14, 2022
Merged
4 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.4 in PR #35385

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Jun 14, 2022
@crazycs520 @ti-srebot
cherry pick pingcap#35367 to release-6.0
5e4475b 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jun 14, 2022
Closed
4 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-6.0 in PR #35386

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Jun 14, 2022
@crazycs520 @ti-srebot
cherry pick pingcap#35367 to release-6.1
b409369 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jun 14, 2022
Merged
4 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-6.1 in PR #35387

@sre-bot
Copy link
Contributor

sre-bot commented Jun 14, 2022

TiDB MergeCI notify

✅ Well Done! New fixed [1] after this pr merged.

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci-tidb/integration-common-test 🔴 failed 2, success 9, total 11 22 min Existing failure
idc-jenkins-ci-tidb/common-test ✅ all 12 tests passed 10 min Fixed
idc-jenkins-ci/integration-cdc-test 🟢 all 34 tests passed 27 min Existing passed
idc-jenkins-ci-tidb/integration-ddl-test 🟢 all 6 tests passed 10 min Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 9 min 2 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 8 min 14 sec Existing passed
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 5 min 40 sec Existing passed
idc-jenkins-ci-tidb/mybatis-test 🟢 all 1 tests passed 3 min 31 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 3 min 21 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

ti-chi-bot pushed a commit that referenced this pull request Jun 17, 2022
@ti-srebot
stmtsummary: fix issue of concurrent map read and write (#35367) (#35384
60be3f4 
)

close #35340
@crazycs520 crazycs520 deleted the fix-stmtsummary-bug branch June 17, 2022 06:34
ti-chi-bot pushed a commit that referenced this pull request Jun 24, 2022
@ti-srebot
stmtsummary: fix issue of concurrent map read and write (#35367) (#35385
6aacaf5 
)

close #35340
zimulala pushed a commit to zimulala/tidb that referenced this pull request Aug 4, 2022
@crazycs520 @zimulala
stmtsummary: fix issue of concurrent map read and write (pingcap#35367)
c744c97 
close pingcap#35340
@zimulala zimulala mentioned this pull request Aug 4, 2022
Merged
ti-chi-bot pushed a commit that referenced this pull request Aug 20, 2022
@ti-srebot
stmtsummary: fix issue of concurrent map read and write (#35367) (#35387
1beb4d4 
)

close #35340
crazycs520 added a commit to ti-srebot/tidb that referenced this pull request Sep 19, 2022
@crazycs520
Revert "cherry pick pingcap#35367 to release-5.0"
e92303e 
This reverts commit ad02543.
crazycs520 added a commit to ti-srebot/tidb that referenced this pull request Sep 19, 2022
@crazycs520
Revert "cherry pick pingcap#35367 to release-5.1"
8f35c83 
This reverts commit a865011.
crazycs520 added a commit to ti-srebot/tidb that referenced this pull request Sep 19, 2022
@crazycs520
Revert "cherry pick pingcap#35367 to release-5.2"
aa85d0f 
This reverts commit b835836.
ti-chi-bot pushed a commit that referenced this pull request Sep 19, 2022
@ti-srebot
stmtsummary: fix issue of concurrent map read and write (#35367) (#35382
03600e8 
)

close #35340
ti-chi-bot pushed a commit that referenced this pull request Sep 19, 2022
@ti-srebot
stmtsummary: fix issue of concurrent map read and write (#35367) (#35381
3aa7f7e 
)

close #35340
ti-chi-bot pushed a commit that referenced this pull request Sep 20, 2022
@ti-srebot
stmtsummary: fix issue of concurrent map read and write (#35367) (#35383
b882aa6 
)

close #35340
@jackysp jackysp mentioned this pull request Nov 18, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tangenta tangenta tangenta approved these changes

@djshow832 djshow832 djshow832 approved these changes

Assignees
No one assigned
Labels
needs-cherry-pick-release-5.0 needs-cherry-pick-release-5.1 needs-cherry-pick-release-5.2 needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 needs-cherry-pick-release-5.4 Type: Need cherry pick to release-5.4 needs-cherry-pick-release-6.1 release-note-none size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

statements_summary has concurrent map read and write
7 participants
@crazycs520 @ti-chi-bot @sre-bot @tangenta @hawkingrei @ti-srebot @djshow832