expression, util: add KeyWithoutTrimRightSpace for collator
#35475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
ti-chi-bot
added
do-not-merge/needs-triage-completed
release-note-none
size/M
|
Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/9d7749d8ce94ef13cb6460e023f038ac42617704 |
tangenta
approved these changes
Jun 17, 2022
likzn
reviewed
Jun 18, 2022
| @@ -560,7 +560,7 @@ func locateStringWithCollation(str, substr, coll string) int64 { | |||
| for { | |||
There was a problem hiding this comment.
Hi, may i ask. What is the effect of this loop? Can we return below code directly?
index := bytes.Index(strKey, subStrKey)
return int64(index + 1)
There was a problem hiding this comment.
no, some of the characters have more than one-byte weight
xiongjiwei
reviewed
Jun 18, 2022
| @@ -28,6 +28,11 @@ func (py *zhPinyinTiDBASCSCollator) Key(str string) []byte { | |||
| panic("implement me") | |||
| } | |||
|
|
|||
| // Collator interface, no implements now. | |||
| func (py *zhPinyinTiDBASCSCollator) KeyWithoutTrimRightSpace(str string) []byte { | |||
xiongjiwei
reviewed
Jun 18, 2022
Co-authored-by: xiongjiwei <xiongjiwei1996@outlook.com>
xiongjiwei
approved these changes
Jun 20, 2022
ti-chi-bot
added
status/LGT2
|
/merge |
|
This pull request has been accepted and is ready to merge. Commit hash: c83cd82
|
ti-chi-bot
added
the
status/can-merge
ti-srebot
pushed a commit
to ti-srebot/tidb
that referenced
this pull request
Jun 20, 2022
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
12 tasks
|
cherry pick to release-5.3 in PR #35517 |
ti-srebot
pushed a commit
to ti-srebot/tidb
that referenced
this pull request
Jun 20, 2022
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
12 tasks
|
cherry pick to release-5.4 in PR #35518 |
ti-srebot
pushed a commit
to ti-srebot/tidb
that referenced
this pull request
Jun 20, 2022
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
12 tasks
|
cherry pick to release-6.0 in PR #35519 |
ti-srebot
pushed a commit
to ti-srebot/tidb
that referenced
this pull request
Jun 20, 2022
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
12 tasks
|
cherry pick to release-6.1 in PR #35520 |
TiDB MergeCI notify✅ Well Done! New fixed [2] after this pr merged.
|
morgo
added a commit
to morgo/tidb
that referenced
this pull request
Jun 28, 2022
* upstream/master: sessionctx: support encoding and decoding session variables (pingcap#35531) planner: add batch_point_get access object (pingcap#35230) sessionctx: set skipInit false for TiDBOptProjectionPushDown and TiDBOptAggPushDown (pingcap#35491) *: add support for disabling noop variables (pingcap#35496) lightning: add store write limiter (pingcap#35193) expression: avoid padding 0 when implicitly cast to binary (pingcap#35053) types: fix creating partition tables fail in ANSI_QUOTES mode (pingcap#35379) executor: add the missed runtime stats when the index merge partial task returns 0 row (pingcap#35297) statistics: batch insert topn and bucket when saving table stats (pingcap#35326) parser: Add support for INTERVAL expr unit + expr (pingcap#30253) (pingcap#35390) config: add missing nodelay example (pingcap#35255) *: Introduce `OptimisticTxnContextProvider` for optimistic txn (pingcap#35131) statistics: fix panic when using wrong globalStats.Indices key (pingcap#35424) *: fix store token is up to the limit in test (pingcap#35374) *: enable more flaky and update bazel config (pingcap#35500) ddl: expose getPrimaryKey() as a public method of model.TableInfo (pingcap#35512) expression, util: add `KeyWithoutTrimRightSpace` for collator (pingcap#35475) infoschema: try on each PD member until one succeeds or all fail (pingcap#35285)
ti-chi-bot
pushed a commit
that referenced
this pull request
Jul 7, 2022
ti-chi-bot
pushed a commit
that referenced
this pull request
Jul 26, 2022
ti-chi-bot
pushed a commit
that referenced
this pull request
Aug 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #35451
Problem Summary:
What is changed and how it works?
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.