*: use generic to improve btree performance

[hawkingrei]

Signed-off-by: Weizhen Wang wangweizhen@pingcap.com

What problem does this PR solve?

Issue Number: close #34248

Problem Summary:

What is changed and how it works?

package tables

import (
	"fmt"
	"testing"

	"github.com/google/btree"
)

func BenchmarkBtree(b *testing.B) {
	bt := btree.New(32)
	for i := 0; i < 64; i++ {
		bt.ReplaceOrInsert(newBtreeListColumnSearchItem(fmt.Sprintf("%d", i)))
	}
	locations := make([]ListPartitionLocation, 0, bt.Len())

	lo := bt.Min()
	hi := bt.Max()

	b.ResetTimer()
	for j := 0; j < b.N; j++ {
		locations = locations[0:]
		bt.AscendRange(lo, hi, func(item btree.Item) bool {
			locations = append(locations, item.(*btreeListColumnItem).location)
			return true
		})
	}
}

func BenchmarkBtreeG(b *testing.B) {
	bt := btree.NewG(32, lessBtreeListColumnItem)
	for i := 0; i < 64; i++ {
		bt.ReplaceOrInsert(newBtreeListColumnSearchItem(fmt.Sprintf("%d", i)))
	}
	locations := make([]ListPartitionLocation, 0, bt.Len())

	lo, _ := bt.Min()
	hi, _ := bt.Max()

	b.ResetTimer()
	for j := 0; j < b.N; j++ {
		locations = locations[0:]
		bt.AscendRange(lo, hi, func(item *btreeListColumnItem) bool {
			locations = append(locations, item.location)
			return true
		})
	}
}

[xhe@ZEN tables]$ go test  -test.run=^$ -bench=. -benchmem
goos: linux
goarch: amd64
pkg: github.com/pingcap/tidb/table/tables
cpu: AMD Ryzen 7 6800U with Radeon Graphics         
BenchmarkBtree-16         256267              4231 ns/op            7882 B/op          0 allocs/op
BenchmarkBtreeG-16        247459              4195 ns/op            8162 B/op          0 allocs/op
PASS
ok      github.com/pingcap/tidb/table/tables    3.148s
[xhe@ZEN tables]$ go test  -test.run=^$ -bench=. -benchmem
goos: linux
goarch: amd64
pkg: github.com/pingcap/tidb/table/tables
cpu: AMD Ryzen 7 6800U with Radeon Graphics         
BenchmarkBtree-16         238915              4198 ns/op            8454 B/op          0 allocs/op
BenchmarkBtreeG-16        263731              3941 ns/op            7659 B/op          0 allocs/op
PASS
ok      github.com/pingcap/tidb/table/tables    3.014s
[xhe@ZEN tables]$ go test  -test.run=^$ -bench=. -benchmem
goos: linux
goarch: amd64
pkg: github.com/pingcap/tidb/table/tables
cpu: AMD Ryzen 7 6800U with Radeon Graphics         
BenchmarkBtree-16         253676              3943 ns/op            7962 B/op          0 allocs/op
BenchmarkBtreeG-16        281829              4119 ns/op            8960 B/op          0 allocs/op
PASS
ok      github.com/pingcap/tidb/table/tables    3.221s

Check List

Tests

• Unit test

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

[ti-chi-bot]

[REVIEW NOTIFICATION]

This pull request has been approved by:

• ngaut
• xhebox

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

[sre-bot]

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/95695651282a8d74c9e0c25078bdb80bdcf434b5

[hawkingrei]

/run-check_dev

[xhebox]

/merge

[ti-chi-bot]

This pull request has been accepted and is ready to merge.

Commit hash: 88cc1a12a0480203559f3619e7b548d6fc488ca0

[hawkingrei]

/hold

it meets the bug from the linter. so we wait for bug fixed.

[xhebox]

My linter told me that type argument [*btreeListColumnItem] is unnecessary.

[hawkingrei]

In the go1.18, Many linter has problems when dealing with generic.

[hawkingrei]

/unhold

[xhebox]

/hold

@hawkingrei check_dev

[2022-06-21T02:12:54.424Z] unconvert check(skip check the generated or copied code in lightning)

[2022-06-21T02:16:16.216Z] 2022/06/21 10:16:10 Unexpected package creation during export data loading

[hawkingrei]

/hold

[hawkingrei]

/merge

[ti-chi-bot]

This pull request has been accepted and is ready to merge.

Commit hash: 5a8e80f022fcce9efb632d08aeb5a9f086a84114

[hawkingrei]

/run-all-tests

[hawkingrei]

/merge

[ti-chi-bot]

This pull request has been accepted and is ready to merge.

Commit hash: 9569565

[hawkingrei]

/hold

[hawkingrei]

/unhold

[sre-bot]

TiDB MergeCI notify

✅ Well Done! New fixed [1] after this pr merged.

CI Name	Result	Duration	Compare with Parent commit
idc-jenkins-ci-tidb/tics-test	🔴 failed 1, success 0, total 1	52 sec	Existing failure
idc-jenkins-ci/integration-cdc-test	✅ all 36 tests passed	27 min	Fixed
idc-jenkins-ci-tidb/integration-common-test	🟢 all 11 tests passed	22 min	Existing passed
idc-jenkins-ci-tidb/common-test	🟢 all 12 tests passed	13 min	Existing passed
idc-jenkins-ci-tidb/integration-ddl-test	🟢 all 6 tests passed	6 min 25 sec	Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2	🟢 all 28 tests passed	5 min 30 sec	Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1	🟢 all 26 tests passed	4 min 23 sec	Existing passed
idc-jenkins-ci-tidb/mybatis-test	🟢 all 1 tests passed	2 min 51 sec	Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test	🟢 all 1 tests passed	2 min 41 sec	Existing passed
idc-jenkins-ci-tidb/plugin-test	🟢 build success, plugin test success	4min	Existing passed