Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

txn: Optimize pessimistic transaction by supporting locking with conflict #35588

Merged
merged 49 commits into from Jan 13, 2023
Merged

txn: Optimize pessimistic transaction by supporting locking with conflict #35588

merged 49 commits into from Jan 13, 2023

Conversation

MyonKeminta
Copy link
Contributor

@MyonKeminta MyonKeminta commented Jun 21, 2022 •
edited

What problem does this PR solve?

Issue Number: Close #40537

Problem Summary:

What is changed and how it works?

Requires tikv/client-go#651.

This PR optimizes pessimistic transaction by supporting pessimistic-locking with conflict and key-grained locking and waiting in TiKV. A system variable controlling the optimization is introduced.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Support aggressive locking model for pessimistic transaction, which can reduce tail latency of point-get DMLs in pessimistic transactions that have frequent lock contention. It can be enabled by the system variable `tidb_pessimistic_txn_aggressive_locking`.

@MyonKeminta
update depencency
4ff1c14
@MyonKeminta
Support aggressive locking
6834395 
Signed-off-by: MyonKeminta <MyonKeminta@users.noreply.github.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jun 21, 2022 •
edited

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • cfzjywxk
  • ekexium

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-linked-issue do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jun 21, 2022
@MyonKeminta
Refactory
776eb75 
Signed-off-by: MyonKeminta <MyonKeminta@users.noreply.github.com>
@ti-chi-bot ti-chi-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jun 21, 2022
@ti-chi-bot ti-chi-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jun 27, 2022
@MyonKeminta
Add metrics
7b7d3d7
@MyonKeminta
Fix bucket settings
5231f1b 
Signed-off-by: MyonKeminta <MyonKeminta@users.noreply.github.com>
@MyonKeminta
update client-go to fix transaction IsReadOnly didn't check aggressiv…
f8e81e3 
…e locking and wrong checking about locking skipping
@MyonKeminta
update client-go
7aadc23
@MyonKeminta
update client-go
90ed173
@MyonKeminta
update client-go
e64d13a 
Signed-off-by: MyonKeminta <MyonKeminta@users.noreply.github.com>
@MyonKeminta
Merge branch 'master' of https://github.com/pingcap/tidb into m/pessi…
879477d 
…mistic-lock-optimize
@MyonKeminta
update client-go to fix some panics
94044ee 
Signed-off-by: MyonKeminta <MyonKeminta@users.noreply.github.com>
@MyonKeminta
update client-go to fix the PessimisticLockNotFound issue
8cb818d 
Signed-off-by: MyonKeminta <MyonKeminta@users.noreply.github.com>
@MyonKeminta
support skipping resolve locks
4979123 
Signed-off-by: MyonKeminta <MyonKeminta@users.noreply.github.com>
@MyonKeminta
Revert "executor: also collect unchanged unique keys for lock (pingca…
da6c7d4 
…p#36498)"

This reverts commit c80026e.
@MyonKeminta MyonKeminta mentioned this pull request Aug 17, 2022
Open
30 tasks
@MyonKeminta
Copy link
Contributor Author

/test build
/test unit-test

@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 11, 2023
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 12, 2023
@MyonKeminta
Copy link
Contributor Author

/test unit-test
/test build

cfzjywxk
cfzjywxk approved these changes Jan 12, 2023
View reviewed changes
Copy link
Contributor

@cfzjywxk cfzjywxk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 12, 2023
@MyonKeminta MyonKeminta mentioned this pull request Jan 12, 2023
Closed
@MyonKeminta
Copy link
Contributor Author

@sticnarf @ekexium PTAL again if you have time, thanks!

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. release-note and removed status/LGT1 Indicates that a PR has LGTM 1. release-note-none labels Jan 12, 2023
@ti-chi-bot
Copy link
Member

@sticnarf: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@MyonKeminta
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

@MyonKeminta: /merge is only allowed for the committers, you can assign this pull request to the committer in list by filling /assign @committer in the comment to help merge this pull request.

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@MyonKeminta
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 3e8604d

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 13, 2023
@ti-chi-bot
Copy link
Member

@MyonKeminta: Your PR was out of date, I have automatically updated it for you.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@MyonKeminta
Copy link
Contributor Author

/test unit-test

@ti-chi-bot ti-chi-bot merged commit b1ecabb into pingcap:master Jan 13, 2023
@MyonKeminta MyonKeminta deleted the m/pessimistic-lock-optimize branch January 13, 2023 03:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cfzjywxk cfzjywxk cfzjywxk approved these changes

@sticnarf sticnarf sticnarf approved these changes

@ekexium ekexium ekexium approved these changes

Assignees
No one assigned
Labels
release-note size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support aggressive-locking model for pessimistic transaction
5 participants
@MyonKeminta @ti-chi-bot @cfzjywxk @sticnarf @ekexium