expression: pushdown reverse to TiFlash #35738

lizhenhuan · 2022-06-25T15:35:57Z

What problem does this PR solve?

Issue Number: close #35754

Problem Summary:
Related Issue: Implements pushdown reverse to TiFlash
pingcap/tiflash#5111
#35754

What is changed and how it works?

Check List

Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No code

Side effects

Performance regression: Consumes more CPU
Performance regression: Consumes more Memory
Breaking backward compatibility

Documentation

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Support to pushdown reverse to TiFlash.

Merge master code from pingcap repo

ti-chi-bot · 2022-06-25T15:35:58Z

[REVIEW NOTIFICATION]

This pull request has been approved by:

XuHuaiyu
zanmato1984

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

sre-bot · 2022-06-25T15:36:06Z

All committers have signed the CLA.

ti-chi-bot · 2022-06-25T15:36:08Z

Welcome @lizhenhuan!

It looks like this is your first PR to pingcap/tidb 🎉.

I'm the bot to help you request reviewers, add labels and more, See available commands.

We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to pingcap/tidb. 😃

Merge from PingCAP Repo

sre-bot · 2022-07-04T10:15:54Z

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/709ae4e74892f419c4d3483d30fe376faeffa589

mengxin9014 · 2022-07-05T06:31:03Z

LGTM

ywqzzy

You need to add tests in planner/core/integration_test.go, you can ref to this pr #35739.

Merge from pingcap repo

XuHuaiyu · 2022-07-12T03:20:11Z

planner/core/integration_test.go

+	rows := [][]interface{}{
+		{"TableReader_9", "root", "data:ExchangeSender_8"},
+		{"└─ExchangeSender_8", "mpp[tiflash]", "ExchangeType: PassThrough"},
+		{"  └─Projection_4", "mpp[tiflash]", "reverse(test.t.a)->Column#3"},


Do we need to test both ScalarFuncSig_ReverseUTF8 and ScalarFuncSig_Reverse

XuHuaiyu · 2022-07-12T04:00:53Z

/merge

ti-chi-bot · 2022-07-12T04:00:55Z

@XuHuaiyu: /merge in this pull request requires 2 approval(s).

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

lizhenhuan · 2022-07-13T02:29:27Z

/run-check_dev

lizhenhuan · 2022-07-13T02:30:07Z

/run-check_dev_2

zanmato1984 · 2022-07-13T02:59:12Z

/lgtm

zanmato1984

LGTM

XuHuaiyu · 2022-07-13T03:18:06Z

/merge

ti-chi-bot · 2022-07-13T03:18:09Z

This pull request has been accepted and is ready to merge.

Commit hash: dc0bae7

sre-bot · 2022-07-13T05:23:28Z

TiDB MergeCI notify

🔴 Bad News! New failing [1] after this pr merged.
These new failed integration tests seem to be caused by the current PR, please try to fix these new failed integration tests, thanks!

CI Name	Result	Duration	Compare with Parent commit
idc-jenkins-ci/integration-cdc-test	🟥 failed 2, success 34, total 36	24 min	New failing
idc-jenkins-ci-tidb/integration-common-test	🟢 all 11 tests passed	24 min	Existing passed
idc-jenkins-ci-tidb/common-test	🟢 all 12 tests passed	14 min	Existing passed
idc-jenkins-ci-tidb/tics-test	🟢 all 1 tests passed	6 min 23 sec	Existing passed
idc-jenkins-ci-tidb/integration-ddl-test	🟢 all 6 tests passed	6 min 16 sec	Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2	🟢 all 28 tests passed	6 min 2 sec	Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1	🟢 all 26 tests passed	5 min 51 sec	Existing passed
idc-jenkins-ci-tidb/mybatis-test	🟢 all 1 tests passed	3 min 13 sec	Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test	🟢 all 1 tests passed	3 min 3 sec	Existing passed
idc-jenkins-ci-tidb/plugin-test	🟢 build success, plugin test success	4min	Existing passed

lizhenhuan added 2 commits June 25, 2022 23:29

Merge pull request #1 from pingcap/master

01a0ed1

Merge master code from pingcap repo

expression: pushdown reverse to TiFlash pingcap#5111

82039a8

ti-chi-bot added do-not-merge/needs-linked-issue release-note size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 25, 2022

lizhenhuan mentioned this pull request Jun 25, 2022

Implement ReverseUTF8/Reverse function push down pingcap/tiflash#5233

Merged

12 tasks

ti-chi-bot removed the do-not-merge/needs-linked-issue label Jun 27, 2022

Merge pull request #2 from pingcap/master

947b2bc

Merge from PingCAP Repo

add test case for reverse function push down to tiflash

99af4b5

ti-chi-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 4, 2022

ywqzzy reviewed Jul 7, 2022

View reviewed changes

Merge pull request #3 from pingcap/master

bd05be6

Merge from pingcap repo

ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 9, 2022

add integration test for reverse

1113574

ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 12, 2022

lizhenhuan added 2 commits July 12, 2022 10:44

resolve confict

d4eddfb

Merge branch 'pingcap-master'

70fbbf0

ti-chi-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 12, 2022

resolve conflict

fbad024

ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jul 12, 2022

XuHuaiyu reviewed Jul 12, 2022

View reviewed changes

add reverseUTF8 and reverse test case

b51ada5

XuHuaiyu approved these changes Jul 12, 2022

View reviewed changes

ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 12, 2022

fix reverse

dc0bae7

lizhenhuan requested a review from ywqzzy July 13, 2022 02:53

zanmato1984 approved these changes Jul 13, 2022

View reviewed changes

ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 13, 2022

ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 13, 2022

ti-chi-bot added 4 commits July 13, 2022 11:18

Merge branch 'master' into master

4e63125

Merge branch 'master' into master

371ebfd

Merge branch 'master' into master

59eb873

Merge branch 'master' into master

709ae4e

ti-chi-bot merged commit 7c45e67 into pingcap:master Jul 13, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

expression: pushdown reverse to TiFlash #35738

expression: pushdown reverse to TiFlash #35738

lizhenhuan commented Jun 25, 2022 •

edited

ti-chi-bot commented Jun 25, 2022 •

edited

sre-bot commented Jun 25, 2022 •

edited

ti-chi-bot commented Jun 25, 2022

sre-bot commented Jul 4, 2022 •

edited

mengxin9014 commented Jul 5, 2022

ywqzzy left a comment

XuHuaiyu Jul 12, 2022

XuHuaiyu commented Jul 12, 2022

ti-chi-bot commented Jul 12, 2022

lizhenhuan commented Jul 13, 2022

lizhenhuan commented Jul 13, 2022

zanmato1984 commented Jul 13, 2022

zanmato1984 left a comment

XuHuaiyu commented Jul 13, 2022

ti-chi-bot commented Jul 13, 2022

sre-bot commented Jul 13, 2022

expression: pushdown reverse to TiFlash #35738

expression: pushdown reverse to TiFlash #35738

Conversation

lizhenhuan commented Jun 25, 2022 • edited

What problem does this PR solve?

What is changed and how it works?

Check List

Release note

ti-chi-bot commented Jun 25, 2022 • edited

sre-bot commented Jun 25, 2022 • edited

ti-chi-bot commented Jun 25, 2022

sre-bot commented Jul 4, 2022 • edited

mengxin9014 commented Jul 5, 2022

ywqzzy left a comment

Choose a reason for hiding this comment

XuHuaiyu Jul 12, 2022

Choose a reason for hiding this comment

XuHuaiyu commented Jul 12, 2022

ti-chi-bot commented Jul 12, 2022

lizhenhuan commented Jul 13, 2022

lizhenhuan commented Jul 13, 2022

zanmato1984 commented Jul 13, 2022

zanmato1984 left a comment

Choose a reason for hiding this comment

XuHuaiyu commented Jul 13, 2022

ti-chi-bot commented Jul 13, 2022

sre-bot commented Jul 13, 2022

TiDB MergeCI notify

lizhenhuan commented Jun 25, 2022 •

edited

ti-chi-bot commented Jun 25, 2022 •

edited

sre-bot commented Jun 25, 2022 •

edited

sre-bot commented Jul 4, 2022 •

edited