Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lightning: revert "sample files and pre-allocate rowID before restoring chunk" #35818

Closed
wants to merge 1 commit into from
Closed

lightning: revert "sample files and pre-allocate rowID before restoring chunk" #35818

wants to merge 1 commit into from

Conversation

sleepymole
Copy link
Contributor

@sleepymole sleepymole commented Jun 29, 2022 •
edited

What problem does this PR solve?

Issue Number: ref #28776

Problem Summary:

What is changed and how it works?

This reverts commit 674def3.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-linked-issue release-note-none size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jun 29, 2022
@sleepymole sleepymole added component/lightning This issue is related to Lightning of TiDB. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jun 29, 2022
@ti-chi-bot ti-chi-bot added needs-cherry-pick-4.0 needs-cherry-pick-release-6.1 size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed do-not-merge/needs-linked-issue labels Jun 29, 2022
@sleepymole
Copy link
Contributor Author

Duplicate with #35817

@sleepymole sleepymole closed this Jun 29, 2022
@sleepymole sleepymole deleted the revert-34288 branch June 29, 2022 07:53
@sre-bot
Copy link
Contributor

sre-bot commented Jun 29, 2022

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/1747381b90c55095b6dd01fc94e48d66633a5fd7

@sleepymole sleepymole restored the revert-34288 branch June 29, 2022 08:03
@sleepymole sleepymole deleted the revert-34288 branch June 29, 2022 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@buchuitoudegou buchuitoudegou Awaiting requested review from buchuitoudegou

Assignees
No one assigned
Labels
component/lightning This issue is related to Lightning of TiDB. needs-cherry-pick-release-6.1 release-note-none size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sleepymole @ti-chi-bot @sre-bot