New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
planner: just pop cte's handleHelper map out since it shouldn't be considered #35854
Conversation
Signed-off-by: AilinKid <314806019@qq.com>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/ccd4fe64d11f83f88af90e3c5e6f996c9ed13af1 |
Signed-off-by: AilinKid <314806019@qq.com>
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 813a8af
|
/run-check_dev_2 |
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
cherry pick to release-5.1 in PR #36567 |
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
cherry pick to release-5.2 in PR #36568 |
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
cherry pick to release-5.3 in PR #36569 |
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
cherry pick to release-5.4 in PR #36570 |
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
cherry pick to release-6.0 in PR #36571 |
cherry pick to release-6.1 in PR #36572 |
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
cherry pick to release-6.2 in PR #36573 |
TiDB MergeCI notify🔴 Bad News! New failing [1] after this pr merged.
|
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
Signed-off-by: AilinKid 314806019@qq.com
What problem does this PR solve?
Issue Number: close #35758
Problem Summary:
What is changed and how it works?
the handleHelper cache an essential handle info for a basic table for every select statement, while after building cte, we should pop it out, because the basic handle info for this select statement will be collected from the datasource when building the tableRef in the next step.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.