Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: just pop cte's handleHelper map out since it shouldn't be considered #35854

Merged
merged 11 commits into from Jul 26, 2022

Conversation

AilinKid
Copy link
Contributor

@AilinKid AilinKid commented Jun 30, 2022

Signed-off-by: AilinKid 314806019@qq.com

What problem does this PR solve?

Issue Number: close #35758

Problem Summary:

What is changed and how it works?

the handleHelper cache an essential handle info for a basic table for every select statement, while after building cte, we should pop it out, because the basic handle info for this select statement will be collected from the datasource when building the tableRef in the next step.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

planner: just pop cte's handleHelper map out since it shouldn't be considered

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jun 30, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • chrysan
  • winoros

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@sre-bot
Copy link
Contributor

sre-bot commented Jun 30, 2022

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 5, 2022
@AilinKid AilinKid requested a review from wjhuang2016 July 5, 2022 07:54
hawkingrei and others added 2 commits July 8, 2022 09:09
Signed-off-by: AilinKid <314806019@qq.com>
@ti-chi-bot ti-chi-bot added needs-cherry-pick-6.2 and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 26, 2022
@AilinKid
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 813a8af

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 26, 2022
@AilinKid
Copy link
Contributor Author

/run-check_dev_2

@ti-chi-bot ti-chi-bot merged commit 1b848f4 into pingcap:master Jul 26, 2022
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Jul 26, 2022
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor

cherry pick to release-5.1 in PR #36567

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Jul 26, 2022
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor

cherry pick to release-5.2 in PR #36568

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Jul 26, 2022
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor

cherry pick to release-5.3 in PR #36569

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Jul 26, 2022
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor

cherry pick to release-5.4 in PR #36570

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Jul 26, 2022
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor

cherry pick to release-6.0 in PR #36571

@ti-srebot
Copy link
Contributor

cherry pick to release-6.1 in PR #36572

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Jul 26, 2022
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor

cherry pick to release-6.2 in PR #36573

@sre-bot
Copy link
Contributor

sre-bot commented Jul 26, 2022

TiDB MergeCI notify

🔴 Bad News! New failing [1] after this pr merged.
These new failed integration tests seem to be caused by the current PR, please try to fix these new failed integration tests, thanks!

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci/integration-cdc-test 🟥 failed 1, success 35, total 36 37 min New failing
idc-jenkins-ci-tidb/integration-common-test 🔴 failed 1, success 10, total 11 52 min Existing failure
idc-jenkins-ci-tidb/integration-ddl-test ✅ all 6 tests passed 8 min 6 sec Fixed
idc-jenkins-ci-tidb/common-test 🟢 all 12 tests passed 19 min Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 7 min 27 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 7 min 6 sec Existing passed
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 5 min 54 sec Existing passed
idc-jenkins-ci-tidb/mybatis-test 🟢 all 1 tests passed 3 min 6 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 2 min 54 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

AilinKid added a commit to ti-srebot/tidb that referenced this pull request Oct 11, 2022
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-cherry-pick-release-5.1 needs-cherry-pick-release-5.2 needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 needs-cherry-pick-release-5.4 Type: Need cherry pick to release-5.4 needs-cherry-pick-release-6.1 release-note size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't find column when update with CTE
8 participants