Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ddl: support adding constraint with column in one spec #36020

Merged
merged 10 commits into from Jul 8, 2022
Merged

ddl: support adding constraint with column in one spec #36020

merged 10 commits into from Jul 8, 2022

Conversation

tangenta
Copy link
Contributor

@tangenta tangenta commented Jul 7, 2022

What problem does this PR solve?

Issue Number: ref #14766

Problem Summary:

This PR supports adding primary key or indexes along with columns:

alter table t add column (b int default 2, index i(a), primary key (a));

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 7, 2022 •
edited

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • xiongjiwei
  • zimulala

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 7, 2022
zimulala
zimulala approved these changes Jul 8, 2022
View reviewed changes
Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 8, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Jul 8, 2022 •
edited

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/df6927282b4d5fcec1f79f30df173a0d8b19f233

xiongjiwei
xiongjiwei reviewed Jul 8, 2022
View reviewed changes
ddl/ddl_api.go
@@ -2997,11 +2997,21 @@ func needToOverwriteColCharset(options []*ast.TableOption) bool {
// `ALTER TABLE ADD COLUMN (c1 INT, c2 INT)` is split into
// `ALTER TABLE ADD COLUMN c1 INT, ADD COLUMN c2 INT`.
func resolveAlterTableAddColumns(spec *ast.AlterTableSpec) []*ast.AlterTableSpec {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the comment should be updated

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As an example, it is still correct.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 8, 2022
@tangenta
Copy link
Contributor Author

tangenta commented Jul 8, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 44ff9f1

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 8, 2022
@tangenta tangenta closed this Jul 8, 2022
@tangenta tangenta reopened this Jul 8, 2022
@tangenta
Copy link
Contributor Author

tangenta commented Jul 8, 2022

/merge

@tangenta
Copy link
Contributor Author

tangenta commented Jul 8, 2022

/rebuild

@ti-chi-bot ti-chi-bot merged commit 959073c into pingcap:master Jul 8, 2022
@tangenta tangenta mentioned this pull request Jul 28, 2022
Closed
39 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zimulala zimulala zimulala approved these changes

@wjhuang2016 wjhuang2016 wjhuang2016 approved these changes

@xiongjiwei xiongjiwei xiongjiwei approved these changes

Assignees
No one assigned
Labels
release-note-none size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@tangenta @ti-chi-bot @sre-bot @zimulala @wjhuang2016 @xiongjiwei