Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

br: block storage based tidb cluster backup and restore #36028

Merged
merged 25 commits into from Feb 16, 2023
Merged

br: block storage based tidb cluster backup and restore #36028

merged 25 commits into from Feb 16, 2023

Conversation

fengou1
Copy link
Contributor

@fengou1 fengou1 commented Jul 8, 2022 •
edited

Function to support AWS EBS snapshot TiDB backup and restore

What problem does this PR solve?

a new feature to solve:

  1. CPU and memory consuming high during the backup.
  2. backup time is too long from the first backup to the last backup even though we already had a previous backup.
  3. restore take a longer time when massive data to restore
    Issue Number: close TiDB Cluster on AWS EBS snapshot Backup & Restore #33849

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 8, 2022 •
edited

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • 3pointer
  • Leavrth

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-linked-issue release-note-none size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jul 8, 2022
@fengou1 fengou1 requested a review from IANTHEREAL July 8, 2022 00:52
@fengou1 fengou1 self-assigned this Jul 8, 2022
@fengou1 fengou1 added the component/br This issue is related to BR of TiDB. label Jul 8, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Jul 8, 2022

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/60d42f72b7bd56b94196c3ec380cee37731c4650

D3Hunter
D3Hunter reviewed Jul 8, 2022
View reviewed changes
docs/design/2022-07-03-block-storage-snapshot-based-backup-restore.md
@@ -0,0 +1,1494 @@
# TiDB Cluster on Amazon EBS Backup & Restore
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move into br/docs/?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not have an idea on it, I put previous the design in that folder, maybe one repo, one design folder? /cc @IANTHEREAL

@fengou1
Copy link
Contributor Author

fengou1 commented Jul 8, 2022

/cc @IANTHEREAL, please help to review the structure and architecture design part.

@fengou1 fengou1 changed the title br: Block Storage Based TiDB Cluster Backup and restore br: block storage based tidb cluster backup and restore Jul 28, 2022
@fengou1 fengou1 mentioned this pull request Aug 4, 2022
Closed
@IANTHEREAL
Copy link
Contributor

Put it all in one directory, just like PITR /docs/design

3pointer
3pointer reviewed Jan 6, 2023
View reviewed changes
docs/design/2022-07-03-block-storage-snapshot-based-backup-restore.md
[K8S CSI driver](https://www.google.com/url?q=https://github.com/kubernetes-sigs/aws-ebs-csi-driver/tree/master/examples/kubernetes/snapshot&sa=D&source=docs&ust=1649386957733703&usg=AOvVaw2a-iF4GtipADKwzRItsAiK)


## Technical Risk
Copy link
Contributor

@3pointer 3pointer Jan 6, 2023 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can remove this part

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix in 0f64aeb

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 3, 2023
@fengou1
Copy link
Contributor Author

fengou1 commented Feb 6, 2023

/merge

@ti-chi-bot
Copy link
Member

@fengou1: /merge in this pull request requires 2 approval(s).

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@fengou1
Copy link
Contributor Author

fengou1 commented Feb 6, 2023

/hold

@ti-chi-bot ti-chi-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 6, 2023
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Feb 16, 2023
@fengou1
Copy link
Contributor Author

fengou1 commented Feb 16, 2023

/unhold

@ti-chi-bot ti-chi-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 16, 2023
@fengou1
Copy link
Contributor Author

fengou1 commented Feb 16, 2023

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 61125f6

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 16, 2023
@fengou1
Copy link
Contributor Author

fengou1 commented Feb 16, 2023

/test unit-test

@ti-chi-bot ti-chi-bot merged commit 6a4475e into pingcap:master Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@D3Hunter D3Hunter D3Hunter left review comments

@3pointer 3pointer 3pointer approved these changes

@Leavrth Leavrth Leavrth approved these changes

@IANTHEREAL IANTHEREAL Awaiting requested review from IANTHEREAL

Assignees

@fengou1 fengou1

Labels
component/br This issue is related to BR of TiDB. release-note-none size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TiDB Cluster on AWS EBS snapshot Backup & Restore
8 participants
@fengou1 @ti-chi-bot @sre-bot @IANTHEREAL @D3Hunter @3pointer @Leavrth @hawkingrei