ddl: implement table granularity DDL for SchemaTracker #36077
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
ti-chi-bot
added
release-note-none
do-not-merge/work-in-progress
Signed-off-by: lance6716 <lance6716@gmail.com>
lance6716
changed the title
ti-chi-bot
added
size/XXL
Signed-off-by: lance6716 <lance6716@gmail.com>
|
Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/6955fd162836d5e4f5e1cb105a43738e70167234 |
wjhuang2016
approved these changes
Jul 12, 2022
Defined2014
reviewed
Jul 12, 2022
| @@ -62,13 +63,32 @@ func (d *Checker) Enable() { | |||
| d.closed = false | |||
| } | |||
|
|
|||
| // CreateTestDB creates a `test` database like the default behaviour of TiDB. | |||
| func (d Checker) CreateTestDB() { | |||
There was a problem hiding this comment.
Could move CreateTestDB and createTestDB into NewSchemaTracker function?
There was a problem hiding this comment.
in normal DM using case, test database is not wanted.
ddl/schematracker/checker.go
Outdated
Comment on lines
122
to
129
| if tableInfo == nil { | ||
| errStr := fmt.Sprintf("%s.%s should not exist", dbName, tableName) | ||
| panic(errStr) | ||
| } | ||
| if tableInfo2 == nil { | ||
| errStr := fmt.Sprintf("%s.%s should exist", dbName, tableName) | ||
| panic(errStr) | ||
| } |
ddl/schematracker/checker.go
Outdated
Comment on lines
82
to
88
| if dbInfo == nil { | ||
| errStr := fmt.Sprintf("%s should not exist", dbName) | ||
| panic(errStr) | ||
| } | ||
| if dbInfo2 == nil { | ||
| errStr := fmt.Sprintf("%s should exist", dbName) | ||
| panic(errStr) |
There was a problem hiding this comment.
Maybe we could combine those lines like
errStr := fmt.Sprintf("inconsistent dbInfo, dbName: %s, real ddl: %p, schematracker：%p", dbName, dbInfo, dbInfo2)
panic(errStr)
I think it's better.
There was a problem hiding this comment.
will do it tomorrow
ti-chi-bot
added
status/LGT2
|
/merge |
|
This pull request has been accepted and is ready to merge. Commit hash: b57935e
|
ti-chi-bot
added
the
status/can-merge
|
/merge |
|
/run-check_dev_2 |
TiDB MergeCI notify🔴 Bad News! New failing [2] after this pr merged.
|
joycse06
added a commit
to joycse06/tidb
that referenced
this pull request
Jul 13, 2022
* master: (27 commits) executor: parallel cancel mpp query (pingcap#36161) store/copr: adjust the cop cache admission process time for paging (pingcap#36157) log-backup: get can restored global-checkpoint-ts when support v3 checkpoint advance (pingcap#36197) executor: optimize cursor read point get by reading through pessimistic lock cache (pingcap#36149) *: add tidb_min_paging_size system variable (pingcap#36107) planner: handle the expected row count for pushed-down selection in mpp (pingcap#36195) *: support show ddl jobs for sub-jobs (pingcap#36168) table-filter: optimize table pattern message and unit tests (pingcap#36160) domain: fix unstable test TestAbnormalSessionPool (pingcap#36154) executor: check the error returned by `handleNoDelay` (pingcap#36105) log-backup: fix checkpoint display (pingcap#36166) store/mockstore/unistore: fix several issues of coprocessor paging in unistore (pingcap#36147) test: refactor restart test (pingcap#36174) ddl: support rename index and columns for multi-schema change (pingcap#36148) test: remove meaningless test and update bazel (pingcap#36136) planner: Reduce verbosity of logging unknown system variables (pingcap#36013) metrics/grafana: bring back the plan cache miss panel (pingcap#36081) ddl: implement table granularity DDL for SchemaTracker (pingcap#36077) *: bazel use jdk 17 (pingcap#36070) telemetry: add reviewer rule (pingcap#36084) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: ref #35933
Problem Summary:
What is changed and how it works?
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.