Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

log-backup: support calculating dynamic shift-start-ts when restoring kv-files belonging to default-cf #36151

Merged
merged 3 commits into from Jul 12, 2022

Conversation

joccau
Copy link
Member

@joccau joccau commented Jul 12, 2022

What problem does this PR solve?

Issue Number: close #36138

Problem Summary:

What is changed and how it works?

This pr is cherry-pick the #36089

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

joccau and others added 2 commits July 12, 2022 20:22
… kv-files belonging to default-cf (pingcap#36089)

* print the size and kv count of truncated log

Signed-off-by: joccau <zak.zhao@pingcap.com>

* calculate shift start ts

Signed-off-by: joccau <zak.zhao@pingcap.com>

* skip invalid meta file

Signed-off-by: joccau <zak.zhao@pingcap.com>

* summary restore log about size and kv-count

Signed-off-by: joccau <zak.zhao@pingcap.com>

* set service-safe-point with global-checkpoint-ts-1

Signed-off-by: joccau <zak.zhao@pingcap.com>

* make fmt

Signed-off-by: joccau <zak.zhao@pingcap.com>

* add test case

Signed-off-by: joccau <zak.zhao@pingcap.com>

* deal comments in pr

Signed-off-by: joccau <zak.zhao@pingcap.com>

* fix typo

Signed-off-by: joccau <zak.zhao@pingcap.com>

* maintain test case

Signed-off-by: joccau <zak.zhao@pingcap.com>

* fix typo

Signed-off-by: joccau <zak.zhao@pingcap.com>

* make build

Signed-off-by: joccau <zak.zhao@pingcap.com>
Signed-off-by: joccau <zak.zhao@pingcap.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 12, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • 3pointer
  • Leavrth

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 12, 2022
Copy link
Contributor

@3pointer 3pointer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 12, 2022
@joccau
Copy link
Member Author

joccau commented Jul 12, 2022

/cc @YuJuncen @Leavrth

@sre-bot
Copy link
Contributor

sre-bot commented Jul 12, 2022

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 12, 2022
@joccau
Copy link
Member Author

joccau commented Jul 12, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 63fe355

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 12, 2022
@ti-chi-bot ti-chi-bot merged commit d214d3e into pingcap:master Jul 12, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Jul 12, 2022

TiDB MergeCI notify

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci/integration-cdc-test 🟢 all 36 tests passed 25 min Existing passed
idc-jenkins-ci-tidb/integration-common-test 🟢 all 11 tests passed 25 min Existing passed
idc-jenkins-ci-tidb/common-test 🟢 all 12 tests passed 22 min Existing passed
idc-jenkins-ci-tidb/integration-ddl-test 🟢 all 6 tests passed 5 min 51 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 5 min 43 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 5 min 18 sec Existing passed
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 4 min 32 sec Existing passed
idc-jenkins-ci-tidb/mybatis-test 🟢 all 1 tests passed 3 min 19 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 2 min 57 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

log-backup: calculate dynamic shift-begin-ts when truncate log
5 participants