Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: fix the issue that binding cannot work when sql_select_limit is enabled #36269

Closed
wants to merge 6 commits into from
Closed

planner: fix the issue that binding cannot work when sql_select_limit is enabled #36269

wants to merge 6 commits into from

Conversation

qw4990
Copy link
Contributor

@qw4990 qw4990 commented Jul 18, 2022

Pick #29789 manually.

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 18, 2022 •
edited

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • chrysan

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot
Copy link
Member

@qw4990: This cherry pick PR is for a release branch and has not yet been approved by release team.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick, it must first be approved by the collaborators.

AFTER it has been approved by collaborators, please ping the release team in a comment to request a cherry pick review.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 18, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Jul 19, 2022 •
edited

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/5137d5bb9a51017822b125e39466fc745aa6291b

Reminiscent
Reminiscent reviewed Jul 19, 2022
View reviewed changes
planner/optimize.go
useBinding = false
}
}
if isStmtNode {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why to add the check for isStmtNode?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TryAddExtraLimit cannot only support StmtNode.

@qw4990
Copy link
Contributor Author

qw4990 commented Jul 19, 2022

/run-all-tests

@qw4990
Copy link
Contributor Author

qw4990 commented Jul 20, 2022

/run-all-tests

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 20, 2022
@xhebox
Copy link
Contributor

xhebox commented Aug 30, 2022

close for DMR version

@xhebox xhebox closed this Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrysan chrysan chrysan approved these changes

@Reminiscent Reminiscent Reminiscent approved these changes

Assignees
No one assigned
Labels
do-not-merge/cherry-pick-not-approved release-note-none size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/LGT1 Indicates that a PR has LGTM 1. type/4.0-cherry-pick
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@qw4990 @ti-chi-bot @sre-bot @xhebox @chrysan @Reminiscent