Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

br: fix broken integration test #36411

Merged
merged 2 commits into from Jul 21, 2022
Merged

br: fix broken integration test #36411

merged 2 commits into from Jul 21, 2022

Conversation

3pointer
Copy link
Contributor

@3pointer 3pointer commented Jul 21, 2022 •
edited

What problem does this PR solve?

Issue Number:

Problem Summary:
After #32169 merged. br will panic in br_incremental_only_ddl tests.
After tikv/tikv#12958 merged. br_other tests will failed due to backup path has changed.

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 21, 2022 •
edited

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • YuJuncen
  • fengou1

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-linked-issue do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 21, 2022
@3pointer
Copy link
Contributor Author

/run-integration-br-tests

@3pointer
Copy link
Contributor Author

/run-integration-br-tests

@3pointer 3pointer marked this pull request as ready for review July 21, 2022 07:27
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 21, 2022
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 21, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 21, 2022
@xiongjiwei
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: f9f1a55

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 21, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Jul 21, 2022 •
edited

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/b223069281dc091d77250bbce6b178f5e3b6c0dc

@wjhuang2016
Copy link
Member

/run-check_dev_2

@ti-chi-bot ti-chi-bot merged commit 656b5a5 into pingcap:master Jul 21, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Jul 21, 2022

TiDB MergeCI notify

🔴 Bad News! [4] CI still failing after this pr merged.
These failed integration tests don't seem to be introduced by the current PR.

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci/integration-cdc-test 🔴 failed 2, success 34, total 36 25 min Existing failure
idc-jenkins-ci-tidb/integration-common-test 🔴 failed 6, success 5, total 11 9 min 42 sec Existing failure
idc-jenkins-ci-tidb/integration-ddl-test 🔴 failed 3, success 3, total 6 6 min 24 sec Existing failure
idc-jenkins-ci-tidb/integration-compatibility-test 🔴 failed 1, success 0, total 1 4 min 12 sec Existing failure
idc-jenkins-ci-tidb/common-test 🟢 all 12 tests passed 21 min Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 11 min Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 7 min 57 sec Existing passed
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 5 min 51 sec Existing passed
idc-jenkins-ci-tidb/mybatis-test 🟢 all 1 tests passed 3 min 23 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

@ti-srebot ti-srebot mentioned this pull request Aug 24, 2022
Merged
12 tasks
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Aug 24, 2022
@3pointer @ti-srebot
cherry pick pingcap#36411 to release-6.1
2aafd03 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor

cherry pick to release-6.1 in PR #37325

@ti-srebot ti-srebot mentioned this pull request Aug 24, 2022
Closed
12 tasks
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Aug 24, 2022
@3pointer @ti-srebot
cherry pick pingcap#36411 to release-5.4
9c29818 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor

cherry pick to release-5.4 in PR #37326

ti-chi-bot pushed a commit that referenced this pull request Aug 24, 2022
@ti-srebot
br: fix broken integration test (#36411) (#37325)
0b00c97
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xiongjiwei xiongjiwei xiongjiwei approved these changes

@YuJuncen YuJuncen YuJuncen approved these changes

@fengou1 fengou1 fengou1 approved these changes

Assignees
No one assigned
Labels
needs-cherry-pick-release-5.4 Type: Need cherry pick to release-5.4 needs-cherry-pick-release-6.1 release-note-none size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. skip-issue-check status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@3pointer @ti-chi-bot @xiongjiwei @sre-bot @wjhuang2016 @ti-srebot @YuJuncen @fengou1