Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lightning: fix check table empty logic #36747

Merged
merged 2 commits into from Aug 1, 2022

Conversation

dsdashun
Copy link
Contributor

@dsdashun dsdashun commented Aug 1, 2022

What problem does this PR solve?

Issue Number: close #36746

Problem Summary:

What is changed and how it works?

Change the is table empty implementation logic: if the table doesn't exist, treat it as a 'table empty' scenario.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below):
    • Create a brand-new TiDB instance
    • Construct a program using the Lightning prechecker on 'table empty' check
    • See the check result and make sure it is passed
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 1, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • D3Hunter
  • gozssky

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none do-not-merge/needs-triage-completed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 1, 2022
@dsdashun
Copy link
Contributor Author

dsdashun commented Aug 1, 2022

/run-integration-br-test

@sre-bot
Copy link
Contributor

sre-bot commented Aug 1, 2022

@dsdashun
Copy link
Contributor Author

dsdashun commented Aug 1, 2022

/cc @D3Hunter @buchuitoudegou @gozssky

@dsdashun
Copy link
Contributor Author

dsdashun commented Aug 1, 2022

/run-build

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 1, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 1, 2022
@dsdashun
Copy link
Contributor Author

dsdashun commented Aug 1, 2022

/run-build

@dsdashun
Copy link
Contributor Author

dsdashun commented Aug 1, 2022

/run-integration-br-test

@dsdashun
Copy link
Contributor Author

dsdashun commented Aug 1, 2022

/merge

@ti-chi-bot
Copy link
Member

@dsdashun: /merge is only allowed for the committers, you can assign this pull request to the committer in list by filling /assign @committer in the comment to help merge this pull request.

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@dsdashun
Copy link
Contributor Author

dsdashun commented Aug 1, 2022

/assign @D3Hunter @gozssky

@sleepymole
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: da21d10

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 1, 2022
@ti-chi-bot ti-chi-bot merged commit 4607cba into pingcap:master Aug 1, 2022
@dsdashun dsdashun deleted the fix_precheck branch August 1, 2022 05:44
@sre-bot
Copy link
Contributor

sre-bot commented Aug 1, 2022

TiDB MergeCI notify

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci/integration-cdc-test 🟢 all 36 tests passed 31 min Existing passed
idc-jenkins-ci-tidb/integration-common-test 🟢 all 17 tests passed 20 min Existing passed
idc-jenkins-ci-tidb/common-test 🟢 all 11 tests passed 18 min Existing passed
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 5 min 39 sec Existing passed
idc-jenkins-ci-tidb/integration-ddl-test 🟢 all 6 tests passed 5 min 27 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 5 min 8 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 4 min 58 sec Existing passed
idc-jenkins-ci-tidb/mybatis-test 🟢 all 1 tests passed 3 min 10 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 3 min 1 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lightning: Check Table Empty Failed When Table Doesn't Exist
5 participants