-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
planner: introduce tidb_general_plan_cache_size for general plan cache #37087
Merged
ti-chi-bot
merged 15 commits into
pingcap:master
from
fzzf678:add_switch_for_general_plan_cache
Aug 16, 2022
Merged
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
1ec1e66
add
fzzf678 546735e
Merge branch 'master' into add_switch_for_general_plan_cache
fzzf678 457f508
Update sysvar_test.go
fzzf678 c06138c
Update tidb_vars.go
fzzf678 99d861c
Update tidb_vars.go
fzzf678 cea0ed9
Merge branch 'master' into add_switch_for_general_plan_cache
fzzf678 98814cb
Update sysvar_test.go
fzzf678 0483828
Merge branch 'add_switch_for_general_plan_cache' of https://github.co…
fzzf678 c039b72
Merge branch 'master' into add_switch_for_general_plan_cache
fzzf678 a4262bb
Update tidb_vars.go
fzzf678 5d364a1
Update tidb_vars.go
fzzf678 b26a884
scope both
fzzf678 c7c179f
update
fzzf678 335bc48
Update session.go
fzzf678 0537a98
Merge branch 'master' into add_switch_for_general_plan_cache
qw4990 File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems the minValue for TiDBPrepPlanCacheSize is 1. See line 781. Should we keep them the same?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we can change this in the next PR or maybe not changed. Both is OK for me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it. Before, minValue = 0 is used to let the general plan cache OFF, I forget to revised back. I 'll fix it in next pr.