New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
planner: introduce the general plan cache #37150
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/474fe88c7e83d49c9b271f94092922254d1d9041 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I prefer use isGeneralPlanCache
instead
Co-authored-by: Song Gao <disxiaofei@163.com>
All updated, PTAL |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 5b35092
|
/merge |
This pull request has been accepted and is ready to merge. Commit hash: d3977d8
|
TiDB MergeCI notify🔴 Bad News! New failing [1] after this pr merged.
|
What problem does this PR solve?
Issue Number: ref #36598
Problem Summary: planner: introduce the general plan cache
What is changed and how it works?
Introduce the general plan cache and refactor the interface to get plan cache from
session.PreparedPlanCache()
tosession.GetPlanCache(generalPlanCache bool)
where the argumentgeneralPlanCache
indicates whether to return the general plan cache or the prepared plan cache.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.