Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: upgrade glangci-linter #37413

Merged
merged 24 commits into from
Sep 1, 2022
Merged

*: upgrade glangci-linter #37413

merged 24 commits into from
Sep 1, 2022

Conversation

hawkingrei
Copy link
Member

@hawkingrei hawkingrei commented Aug 27, 2022 •
edited
Loading

What problem does this PR solve?

Issue Number: close #xxx

Problem Summary:

What is changed and how it works?

varcheck, deadcode, and structcheck are deprecated.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 27, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Yisaer
  • ngaut

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 27, 2022
@hawkingrei hawkingrei added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 27, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Aug 27, 2022 •
edited by ti-chi-bot
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/3ad9a215fa44cafa00ed862279522dde041bb128

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 27, 2022
@ngaut
Copy link
Member

ngaut commented Aug 27, 2022

Good job, Could you create an issue to track all of these trivial improvements?

@ti-chi-bot ti-chi-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 29, 2022
@hawkingrei hawkingrei added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Aug 29, 2022
@hawkingrei hawkingrei mentioned this pull request Aug 30, 2022
Open
@hawkingrei hawkingrei force-pushed the updategcl branch 3 times, most recently from 7f29c8d to 48d46a3 Compare August 31, 2022 11:35
@hawkingrei
*: upgrade glangci-linter
fbb4ecf 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei
*: upgrade glangci-linter
c4dc0be 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei
*: upgrade glangci-linter
af5c9b5 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei
update
ff7d641
@hawkingrei
update
f643ffd
@hawkingrei
update
6a47c3e
@hawkingrei
update
28769f3
@hawkingrei
*: update bazel config
e5e0513 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei
*: update bazel config
94c569b 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei
infoschema: remove useless code
05d1a6a 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei
infoschema: remove useless code
7a16048 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei
infoschema: remove useless code
8980fb8 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei
infoschema: remove useless code
f424090 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei
infoschema: remove useless code
edc0b3d 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei
update
4a83bbe 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei
update
56096e9 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei
update
0fef54d 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei
update
ffcd435 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei
update
89d76bb 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei
update
4f1c5e1 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei
update
76e9e47 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei
update
bf2d2e7 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei
update
3ad9a21 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei hawkingrei removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 1, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 1, 2022
@hawkingrei
Copy link
Member Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: eafa556

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 1, 2022
@ti-chi-bot ti-chi-bot merged commit 6e58264 into pingcap:master Sep 1, 2022
@hawkingrei hawkingrei deleted the updategcl branch September 1, 2022 04:23
@sre-bot
Copy link
Contributor

sre-bot commented Sep 1, 2022

TiDB MergeCI notify

🔴 Bad News! New failing [2] after this pr merged.
These new failed integration tests seem to be caused by the current PR, please try to fix these new failed integration tests, thanks!

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci-tidb/integration-compatibility-test 🟥 failed 1, success 0, total 1 5 min 20 sec New failing
idc-jenkins-ci-tidb/tics-test 🟥 failed 1, success 0, total 1 5 min 12 sec New failing
idc-jenkins-ci-tidb/integration-common-test 🔴 failed 1, success 16, total 17 15 min Existing failure
idc-jenkins-ci-tidb/common-test 🔴 failed 1, success 10, total 11 13 min Existing failure
idc-jenkins-ci/integration-cdc-test 🟢 all 37 tests passed 28 min Existing passed
idc-jenkins-ci-tidb/integration-ddl-test 🟢 all 6 tests passed 7 min 22 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 4 min 53 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 4 min 37 sec Existing passed
idc-jenkins-ci-tidb/mybatis-test 🟢 all 1 tests passed 3 min 17 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ngaut ngaut ngaut approved these changes

@Yisaer Yisaer Yisaer approved these changes

@xhebox xhebox Awaiting requested review from xhebox

@tangenta tangenta Awaiting requested review from tangenta

Assignees
No one assigned
Labels
release-note-none size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@hawkingrei @ti-chi-bot @sre-bot @ngaut @Yisaer