New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
util/size: define some constants for size #37468
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Have some problem about lint. Please fix it. |
Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/acc4d32b28d9378a905c76f1d75476a78b04c9c5 |
/merge |
1 similar comment
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 043ab16
|
This pull request has been accepted and is ready to merge. Commit hash: 043ab16
|
TiDB MergeCI notify🔴 Bad News! [2] CI still failing after this pr merged.
|
What problem does this PR solve?
Problem Summary:
We can extract the size constants to a dedicated package for reuse.
What is changed and how it works?
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.