Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: PhysicalPlan memory trace 1 #37655

Merged
merged 11 commits into from Sep 8, 2022
Merged

planner: PhysicalPlan memory trace 1 #37655

merged 11 commits into from Sep 8, 2022

Conversation

fzzf678
Copy link
Contributor

@fzzf678 fzzf678 commented Sep 7, 2022 •
edited

What problem does this PR solve?

Issue Number: ref #37632

Problem Summary:

What is changed and how it works?

Add MemoryUsage() for

  • PhysicalSort
  • NominalSort

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 7, 2022 •
edited

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Reminiscent
  • qw4990

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none labels Sep 7, 2022
@ti-chi-bot ti-chi-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 7, 2022
@fzzf678 fzzf678 marked this pull request as ready for review September 7, 2022 07:03
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 7, 2022
@fzzf678
Copy link
Contributor Author

fzzf678 commented Sep 7, 2022

/cc @XuHuaiyu @wshwsh12

@fzzf678 fzzf678 changed the title planner: PhysicalPlan memory trace 01 planner: PhysicalPlan memory trace 1 Sep 7, 2022
@qw4990 qw4990 added the sig/planner SIG: Planner label Sep 8, 2022
qw4990
qw4990 reviewed Sep 8, 2022
View reviewed changes
util/memory/tracker.go Outdated
const SizeOfString = int64(unsafe.Sizeof(*new(string)))

// SizeOfBool is the memory each bool occupied
const SizeOfBool = int64(unsafe.Sizeof(*new(bool)))

// SizeOfPointer is the memory each pointer occupied
const SizeOfPointer = int64(unsafe.Sizeof(new(int)))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please move these definations to util/size/size.go.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 8, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 8, 2022
@Reminiscent
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: b533da0

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 8, 2022
@ti-chi-bot ti-chi-bot merged commit 330ed6d into pingcap:master Sep 8, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Sep 8, 2022

TiDB MergeCI notify

🔴 Bad News! New failing [1] after this pr merged.
These new failed integration tests seem to be caused by the current PR, please try to fix these new failed integration tests, thanks!

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci-tidb/integration-common-test 🟥 failed 2, success 15, total 17 17 min New failing
idc-jenkins-ci-tidb/integration-ddl-test 🔴 failed 2, success 4, total 6 13 min Existing failure
idc-jenkins-ci-tidb/common-test 🔴 failed 1, success 10, total 11 12 min Existing failure
idc-jenkins-ci/integration-cdc-test 🟢 all 37 tests passed 26 min Existing passed
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 6 min 23 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 5 min 1 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 4 min 25 sec Existing passed
idc-jenkins-ci-tidb/mybatis-test 🟢 all 1 tests passed 3 min 34 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 2 min 53 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

@fzzf678 fzzf678 mentioned this pull request Sep 14, 2022
Closed
25 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qw4990 qw4990 qw4990 approved these changes

@Reminiscent Reminiscent Reminiscent approved these changes

@wshwsh12 wshwsh12 Awaiting requested review from wshwsh12

@XuHuaiyu XuHuaiyu Awaiting requested review from XuHuaiyu

Assignees
No one assigned
Labels
release-note-none sig/planner SIG: Planner size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@fzzf678 @ti-chi-bot @Reminiscent @sre-bot @qw4990