Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

statistics: fix unstable TestAnalyzeGlobalStatsWithOpts2 #37705

Merged
merged 4 commits into from Sep 8, 2022
Merged

statistics: fix unstable TestAnalyzeGlobalStatsWithOpts2 #37705

merged 4 commits into from Sep 8, 2022

Conversation

Yisaer
Copy link
Contributor

@Yisaer Yisaer commented Sep 8, 2022 •
edited

Signed-off-by: yisaer disxiaofei@163.com

What problem does this PR solve?

Issue Number: ref #37647

Problem Summary:

What is changed and how it works?

Fix the unstable data distribution

Check List

Tests

  • Unit test

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@Yisaer
fix
2ff16a4 
Signed-off-by: yisaer <disxiaofei@163.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 8, 2022 •
edited

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • hawkingrei
  • xuyifangreeneyes

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 8, 2022
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 8, 2022
@Yisaer
Copy link
Contributor Author

Yisaer commented Sep 8, 2022

/hold

@ti-chi-bot ti-chi-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 8, 2022
@hawkingrei hawkingrei self-requested a review September 8, 2022 05:39
@Yisaer
fix
860e68f 
Signed-off-by: yisaer <disxiaofei@163.com>
@ti-chi-bot ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 8, 2022
@Yisaer
Copy link
Contributor Author

Yisaer commented Sep 8, 2022

/hold cancel

@ti-chi-bot ti-chi-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 8, 2022
xuyifangreeneyes
xuyifangreeneyes approved these changes Sep 8, 2022
View reviewed changes
Copy link
Contributor

@xuyifangreeneyes xuyifangreeneyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest LGTM

statistics/handle/handle_test.go Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 8, 2022
@Yisaer
fix
8d644c4 
Signed-off-by: yisaer <disxiaofei@163.com>
@Yisaer
Copy link
Contributor Author

Yisaer commented Sep 8, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 8d644c4

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 8, 2022
@ti-chi-bot ti-chi-bot merged commit 0fb8ae8 into pingcap:master Sep 8, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Sep 8, 2022

TiDB MergeCI notify

🔴 Bad News! [1] CI still failing after this pr merged.
These failed integration tests don't seem to be introduced by the current PR.

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci-tidb/common-test 🔴 failed 1, success 10, total 11 13 min Existing failure
idc-jenkins-ci/integration-cdc-test 🟢 all 37 tests passed 26 min Existing passed
idc-jenkins-ci-tidb/integration-common-test 🟢 all 17 tests passed 16 min Existing passed
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 8 min 24 sec Existing passed
idc-jenkins-ci-tidb/integration-ddl-test 🟢 all 6 tests passed 6 min 3 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 5 min 39 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 5 min 21 sec Existing passed
idc-jenkins-ci-tidb/mybatis-test 🟢 all 1 tests passed 3 min 42 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 2 min 53 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

@chrysan chrysan added the needs-cherry-pick-release-5.4 Type: Need cherry pick to release-5.4 label Sep 22, 2022
@ti-srebot ti-srebot mentioned this pull request Sep 22, 2022
Merged
1 task
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Sep 22, 2022
@Yisaer @ti-srebot
cherry pick pingcap#37705 to release-5.4
de95d84 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor

cherry pick to release-5.4 in PR #38084

ti-chi-bot pushed a commit that referenced this pull request Sep 22, 2022
@ti-srebot
statistics: fix unstable TestAnalyzeGlobalStatsWithOpts2 (#37705) (#3…
4f28cc6 
…8084)

ref #37647
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hawkingrei hawkingrei hawkingrei approved these changes

@xuyifangreeneyes xuyifangreeneyes xuyifangreeneyes approved these changes

Assignees
No one assigned
Labels
needs-cherry-pick-release-5.4 Type: Need cherry pick to release-5.4 release-note-none size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@Yisaer @ti-chi-bot @sre-bot @ti-srebot @hawkingrei @xuyifangreeneyes @chrysan