Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DDL: update TiFlash replica progress after available #37766

Merged
merged 11 commits into from Sep 22, 2022
Merged

DDL: update TiFlash replica progress after available #37766

merged 11 commits into from Sep 22, 2022

Conversation

hehechen
Copy link
Contributor

@hehechen hehechen commented Sep 13, 2022 •
edited

Signed-off-by: hehechen awd123456sss@gmail.com

What problem does this PR solve?

Issue Number: ref pingcap/tiflash#4902

Problem Summary:

What is changed and how it works?

Update TiFlash replica progress after available.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
    Create table and then import data using lightning, check if the progress will update.
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 13, 2022 •
edited

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • breezewish
  • crazycs520

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/invalid-title release-note-none do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 13, 2022
@hehechen hehechen changed the title update_progress update TiFlash replica progress after available Sep 13, 2022
@hehechen hehechen changed the title update TiFlash replica progress after available DDL: update TiFlash replica progress after available Sep 13, 2022
@hehechen
Copy link
Contributor Author

/rebuild

1 similar comment
@hehechen
Copy link
Contributor Author

/rebuild

@hehechen hehechen marked this pull request as ready for review September 13, 2022 09:03
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 13, 2022
@hehechen
Copy link
Contributor Author

/rebuild

@hehechen hehechen force-pushed the update_progress branch 2 times, most recently from ea3ec6e to 375fdef Compare September 13, 2022 15:47
@ti-chi-bot ti-chi-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 13, 2022
@hehechen hehechen force-pushed the update_progress branch 2 times, most recently from bf0b030 to dd9fd1e Compare September 13, 2022 16:04
@hehechen
Copy link
Contributor Author

/run-mysql-test

@hehechen
update_progress
8ca0deb 
Signed-off-by: hehechen <awd123456sss@gmail.com>
@hehechen
Copy link
Contributor Author

/cc @breezewish

CalvinNeo
CalvinNeo reviewed Sep 14, 2022
View reviewed changes
ddl/ddl_tiflash_api.go Outdated Show resolved Hide resolved
CalvinNeo
CalvinNeo reviewed Sep 14, 2022
View reviewed changes
server/http_handler.go Outdated Show resolved Hide resolved
CalvinNeo
CalvinNeo reviewed Sep 14, 2022
View reviewed changes
ddl/ddl_tiflash_api.go Outdated Show resolved Hide resolved
@hehechen hehechen force-pushed the update_progress branch 2 times, most recently from ff08331 to fcb8e23 Compare September 14, 2022 09:28
@ti-chi-bot ti-chi-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Sep 15, 2022
@hehechen
Copy link
Contributor Author

/run-check_dev_2

CalvinNeo
CalvinNeo approved these changes Sep 15, 2022
View reviewed changes
Copy link
Member

@CalvinNeo CalvinNeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-chi-bot
Copy link
Member

@CalvinNeo: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@hehechen
Copy link
Contributor Author

/run-tests

@hehechen
fix change tiflash replica
bc45f6c 
Signed-off-by: hehechen <awd123456sss@gmail.com>
@hehechen
optimize code
8585d5c 
Signed-off-by: hehechen <awd123456sss@gmail.com>
breezewish
breezewish reviewed Sep 20, 2022
View reviewed changes
Copy link
Member

@breezewish breezewish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The logic generally looks good. Some structural suggestions.

ddl/ddl_tiflash_api.go Outdated Show resolved Hide resolved
ddl/ddl_tiflash_api.go Outdated Show resolved Hide resolved
ddl/ddl_tiflash_api.go Outdated Show resolved Hide resolved
ddl/ddl_tiflash_api.go Outdated Show resolved Hide resolved
ddl/ddl_tiflash_api.go Show resolved Hide resolved
ddl/ddl_tiflash_api.go Show resolved Hide resolved
ddl/ddl_tiflash_api.go Outdated Show resolved Hide resolved
ddl/ddl_tiflash_api.go Outdated Show resolved Hide resolved
ddl/ddl_tiflash_api.go Outdated Show resolved Hide resolved
ddl/ddl_tiflash_api.go Outdated Show resolved Hide resolved
@hehechen hehechen requested review from breezewish and removed request for crazycs520 September 20, 2022 11:49
@hehechen
fix comment
c0ce42b 
Signed-off-by: hehechen <awd123456sss@gmail.com>
breezewish
breezewish approved these changes Sep 21, 2022
View reviewed changes
Copy link
Member

@breezewish breezewish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Looking forward to have a simpler implementation in future!

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 21, 2022
@hehechen
Copy link
Contributor Author

/assign @breezewish

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 22, 2022
@breezewish
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 0b6d113

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 22, 2022
@ti-chi-bot ti-chi-bot merged commit 319b320 into pingcap:master Sep 22, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Sep 22, 2022

TiDB MergeCI notify

✅ Well Done! New fixed [1] after this pr merged.

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci-tidb/integration-common-test ✅ all 17 tests passed 12 min Fixed
idc-jenkins-ci/integration-cdc-test 🟢 all 37 tests passed 31 min Existing passed
idc-jenkins-ci-tidb/integration-ddl-test 🟢 all 6 tests passed 29 min Existing passed
idc-jenkins-ci-tidb/common-test 🟢 all 11 tests passed 9 min 12 sec Existing passed
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 7 min 7 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 4 min 29 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 4 min 9 sec Existing passed
idc-jenkins-ci-tidb/mybatis-test 🟢 all 1 tests passed 2 min 59 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 2 min 39 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@breezewish breezewish breezewish approved these changes

@CalvinNeo CalvinNeo CalvinNeo approved these changes

@crazycs520 crazycs520 crazycs520 approved these changes

Assignees

@breezewish breezewish

Labels
release-note-none size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@hehechen @ti-chi-bot @breezewish @sre-bot @CalvinNeo @crazycs520