executor: let PlanReplayerExec support multi sqls #37799
Conversation
Signed-off-by: yisaer <disxiaofei@163.com>
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
ti-chi-bot
added
release-note-none
size/L
Yisaer
requested review from
xuyifangreeneyes,
time-and-fate,
hawkingrei and
qw4990
| func dumpExplain(ctx sessionctx.Context, zw *zip.Writer, execStmts []ast.StmtNode, isAnalyze bool) error { | ||
| for i, stmtExec := range execStmts { | ||
| sql := stmtExec.Text() | ||
| var recordSets []sqlexec.RecordSet |
There was a problem hiding this comment.
Can these recordSets be reused?
There was a problem hiding this comment.
I think it's not necessary here.
Signed-off-by: yisaer <disxiaofei@163.com>
ti-chi-bot
added
status/LGT2
|
/merge |
|
This pull request has been accepted and is ready to merge. Commit hash: 6cf1af8
|
ti-chi-bot
added
the
status/can-merge
TiDB MergeCI notify🔴 Bad News! [2] CI still failing after this pr merged.
|
Signed-off-by: yisaer disxiaofei@163.com
What problem does this PR solve?
Issue Number: ref #37798
Problem Summary:
What is changed and how it works?
let PlanReplayerExec support multi sqls
Check List
Tests
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.