New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
planner: remove old useless interfaces about cost model #37801
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
9fd4663
to
7ad5893
Compare
b0c24ac
to
49fa79a
Compare
e720037
to
b895dca
Compare
I wrote a UT locally to compare costs of all queries in
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rest lgtm
@@ -1918,7 +1918,6 @@ func appendChildCandidate(origin PhysicalPlan, pp PhysicalPlan, op *physicalOpti | |||
PlanTrace: &tracing.PlanTrace{ | |||
ID: pp.ID(), | |||
TP: pp.TP(), | |||
Cost: pp.Cost(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
leave a TODO here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added. PTAL.
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 813c3b7
|
/merge |
@qw4990: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
What problem does this PR solve?
Issue Number: ref #35240
Problem Summary: planner: remove old useless interfaces about cost model
What is changed and how it works?
No logical change, just refactor, remove some old and useless cost interfaces:
Now, all logic related to the cost model is in
plan_cost.go
.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.