New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: Always generate global stats for partitioned tables #37830

Draft

mjonss wants to merge 18 commits into pingcap:master from mjonss:always-glob-stats

Contributor

mjonss commented Sep 14, 2022

What problem does this PR solve?

Issue Number: close #xxx

Problem Summary:

Always generate global statistics for partitioned tables.

Reverts the PR that falls back on static prune mode if global statistics does not exist.

What is changed and how it works?

Check List

Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No code

Side effects

Performance regression: Consumes more CPU
Performance regression: Consumes more Memory
Breaking backward compatibility

Documentation

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Always generate global/table level statistics for partitioned tables, regardless of the tidb_partition_prune_mode setting.

mjonss added 11 commits

September 12, 2022 10:56


          executor: Always add global stats for partitioned tables

872dabf


          Updated testcase result

5bf1ec3


          Updated test testAnalyzeIncremental due to always doing global stats

da913e8


          Updated test case

55638ff


          Updated testcase

0af1cf5


          Always include global stats in SHOW {stats_meta,stats_histograms}

2c0b359


          Updated a test case

7f0aa55


          Updated test cases

dc30ed2


          Revert "planner: add warning if fallback to static plan from dynamic (p…

75f073c

…ingcap#37767)"

This reverts commit e68227c.


          Revert "planner: fallback to static plan for partition table if havin…

0bcbad9

…g no global stats in dynamic prune mode (pingcap#37573)"

This reverts commit 7eb7ca9.

But keeps the tests


          Merge branch 'global-stats-always' into always-glob-stats

95571ad

Member

ti-chi-bot commented Sep 14, 2022

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

ti-chi-bot added do-not-merge/invalid-title release-note do-not-merge/work-in-progress size/XL labels

mjonss changed the title ~~Always glob stats~~ *: Always generate global stats for partitioned tables

ti-chi-bot removed the do-not-merge/invalid-title label


          Updated test results

67b9cca

ti-chi-bot added size/XXL and removed size/XL labels

Contributor Author

mjonss commented Sep 16, 2022

/run-unit-test

mjonss added 2 commits

September 16, 2022 13:03


          Merge remote-tracking branch 'pingcap/master' into always-glob-stats

abb2911


          Updated test

67ccb8b

ti-chi-bot added needs-rebase and removed needs-rebase labels

Member

hawkingrei commented Sep 17, 2022

/run-unit-test

Contributor Author

mjonss commented Sep 19, 2022

/run-mysql-test tidb-test=pr/1975


          Merge remote-tracking branch 'pingcap/master' into always-glob-stats

5a7f3ac

Contributor Author

mjonss commented Sep 19, 2022

/run-mysql-test tidb-test=pr/1975


          Merge branch 'master' into always-glob-stats

cdad70c

Contributor Author

mjonss commented Sep 19, 2022

/run-mysql-test tidb-test=pr/1975


          Merge branch 'master' into always-glob-stats

57e6ed3

Contributor Author

mjonss commented Sep 19, 2022

/run-mysql-test tidb-test=pr/1975

1 similar comment

Contributor Author

mjonss commented Sep 19, 2022

/run-mysql-test tidb-test=pr/1975

Contributor Author

mjonss commented Sep 21, 2022

/run-check_dev_2

mjonss mentioned this pull request

parser: allow drop stats of multiple tables #38042

Merged

4 tasks

ti-chi-bot added the needs-rebase label


          Merge remote-tracking branch 'pingcap/master' into always-glob-stats

2109f69

ti-chi-bot removed the needs-rebase label

Contributor Author

mjonss commented Sep 28, 2022

/run-mysql-test tidb-test=pr/1975

ti-chi-bot added the needs-rebase label

Member

ti-chi-bot commented Oct 22, 2022

@mjonss: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ti-chi-bot bot deleted a comment from ti-chi-bot

ti-chi-bot bot commented Apr 10, 2024

@mjonss: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
idc-jenkins-ci-tidb/check_dev_2	`2109f69`	link	true	`/test check-dev2`
idc-jenkins-ci-tidb/mysql-test	`2109f69`	link	true	`/test mysql-test`
idc-jenkins-ci-tidb/check_dev	`2109f69`	link	true	`/test check-dev`
idc-jenkins-ci-tidb/build	`2109f69`	link	true	`/test build`
idc-jenkins-ci-tidb/unit-test	`2109f69`	link	true	`/test unit-test`
pull-mysql-client-test	`2109f69`	link	true	`/test pull-mysql-client-test`
pull-integration-ddl-test	`2109f69`	link	true	`/test pull-integration-ddl-test`
pull-br-integration-test	`2109f69`	link	true	`/test pull-br-integration-test`
pull-lightning-integration-test	`2109f69`	link	true	`/test pull-lightning-integration-test`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment